Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal Dialog fires dismiss on close #1149

Closed
2 tasks done
ThomasPoenicke opened this issue Mar 8, 2024 · 1 comment · Fixed by #1489
Closed
2 tasks done

Modal Dialog fires dismiss on close #1149

ThomasPoenicke opened this issue Mar 8, 2024 · 1 comment · Fixed by #1489
Labels
type: bug Something isn't working Workflow: Issue created JIRA issue is created and will be analyzed

Comments

@ThomasPoenicke
Copy link

Prerequisites

  • I have not leaked any internal company information.
  • I have not posted internal links or code snippets.

What happened?

When closing a Modal Dialog using IxActiveModal.close(reason) method, a dismiss event is fired additionally.
This leads into unexpected behavior as the dismiss event is also subscribed.

The stackblitz example shows, that closing a modal dialog (by x, cancel, ok) leads into 2 events, where the second event is always 'dismiss'.

What type of frontend frameware are you seeing the problem on?

Angular

Which version of iX do you use?

v2.1.0

Code to produce this issue.

https://stackblitz.com/edit/k5zpnl-dgfcmz
@ThomasPoenicke ThomasPoenicke added the triage We discuss this topic in our internal weekly label Mar 8, 2024
@matthiashader
Copy link
Collaborator

Thanks for your report we will have a look into it! Internal ref [IX-985]

@matthiashader matthiashader added type: bug Something isn't working Workflow: Issue created JIRA issue is created and will be analyzed and removed triage We discuss this topic in our internal weekly labels Mar 13, 2024
@matthiashader matthiashader mentioned this issue Sep 19, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working Workflow: Issue created JIRA issue is created and will be analyzed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core/modal): fires 2 events on closing siemens/ix
2 participants
@ThomasPoenicke @matthiashader