-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initialized the enchancement of the client side developer experience #44
base: main
Are you sure you want to change the base?
initialized the enchancement of the client side developer experience #44
Conversation
Thanks @zt4ff, I will take some time to review this PR since it brings in a couple of changes. Can we also add eslint/prettier, and create a GitHub pipeline to validate lint and build? If you don't want to add it to this PR, I can fork another issue and it can be worked on separately as well. |
Thanks @shubham1172. You can create a new issue for the eslint/prettier, Github pipeline in a new issues. I don't think they relate to the build process. I may be wrong though |
Well, they are a part of the build IMO - builds must be validated on PRs, and their validity should also depend on the code (linting/pretty), but I won't increase the scope of this PR further and create a separate issue. |
Alright, you can assign the new issue to me whenever you review this PR or should I just configure linting while this PR is open? |
I will look at this PR over the weekend and also create a separate issue for the other things we discussed. |
Co-authored-by: Shubham Sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now the root of this project is a python web server. Can we move the web part to a separate folder, web
, that contains typescript code and configuration. The static
folder can stay as is (outside web
). This will help us clearly identify what does what.
Hi @shubham1172 |
Thanks for making those changes @zt4ff, this LGTM, I will try this out and merge the PR once I am done! |
@zt4ff sorry for getting late to this (and it's ok if you don't have bandwidth to look into this), this PR does not seem to be working. After running the
|
Hi, it's beena a while. Happy new year I made new changes to fix the errors. You can build the frontend with |
Hi @shubham1172
Since there's no specific direction to enhancing the client-side dev experience, I made the following as minimal as I could get.
Everything works fine , I look forward to your review and opinion.