Skip to content

Commit

Permalink
Update article
Browse files Browse the repository at this point in the history
  • Loading branch information
shiro committed Apr 28, 2024
1 parent 70325e6 commit e901355
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions src/DialogImage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ const _Thumbnail = css``;
const _FullscreenImage = css`
--w_limit: 90vw !important;
--h_limit: 90vh !important;
// don't upscale
max-width: calc(var(--width) * 1px);
max-height: calc(var(--height) * 1px);
`;

export default withStyle(DialogImage, { Thumbnail: _Thumbnail });
2 changes: 0 additions & 2 deletions src/LazyImage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ const _LazyImage = css`
--sf_px: min(var(--x_sf_px), var(--y_sf_px));
width: calc((var(--width) * var(--sf_px) / 100));
height: calc((var(--height) * var(--sf_px) / 100));
max-width: calc(var(--width) * 1px);
max-height: calc(var(--height) * 1px);
${breakpoint("xs")} {
object-fit: cover !important;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,9 @@ caption="The workflow finished successfully"
/>

Let's try opening the page and ensuring everything works as it should.
Also check for any errors in the console and try clicking the button to increase the counter.
If the counter works, it means that JS hydrated successfully and client side Javascript works
as expected.

<Img
src={p3}
Expand Down

0 comments on commit e901355

Please sign in to comment.