File tree Expand file tree Collapse file tree 3 files changed +7
-2
lines changed
articles/2024-04-28-deploying-a-solid-start-app-to-github-pages Expand file tree Collapse file tree 3 files changed +7
-2
lines changed Original file line number Diff line number Diff line change @@ -55,6 +55,10 @@ const _Thumbnail = css``;
55
55
const _FullscreenImage = css `
56
56
--w_limit : 90vw !important ;
57
57
--h_limit : 90vh !important ;
58
+
59
+ // don't upscale
60
+ max-width : calc (var (--width ) * 1px );
61
+ max-height : calc (var (--height ) * 1px );
58
62
` ;
59
63
60
64
export default withStyle ( DialogImage , { Thumbnail : _Thumbnail } ) ;
Original file line number Diff line number Diff line change @@ -66,8 +66,6 @@ const _LazyImage = css`
66
66
--sf_px : min (var (--x_sf_px ), var (--y_sf_px ));
67
67
width : calc ((var (--width ) * var (--sf_px ) / 100 ));
68
68
height : calc ((var (--height ) * var (--sf_px ) / 100 ));
69
- max-width : calc (var (--width ) * 1px );
70
- max-height : calc (var (--height ) * 1px );
71
69
72
70
${ breakpoint ( "xs" ) } {
73
71
object-fit : cover !important ;
Original file line number Diff line number Diff line change @@ -215,6 +215,9 @@ caption="The workflow finished successfully"
215
215
/>
216
216
217
217
Let's try opening the page and ensuring everything works as it should.
218
+ Also check for any errors in the console and try clicking the button to increase the counter.
219
+ If the counter works, it means that JS hydrated successfully and client side Javascript works
220
+ as expected.
218
221
219
222
<Img
220
223
src = { p3 }
You can’t perform that action at this time.
0 commit comments