Skip to content

Commit e901355

Browse files
committed
Update article
1 parent 70325e6 commit e901355

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

src/DialogImage.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,10 @@ const _Thumbnail = css``;
5555
const _FullscreenImage = css`
5656
--w_limit: 90vw !important;
5757
--h_limit: 90vh !important;
58+
59+
// don't upscale
60+
max-width: calc(var(--width) * 1px);
61+
max-height: calc(var(--height) * 1px);
5862
`;
5963

6064
export default withStyle(DialogImage, { Thumbnail: _Thumbnail });

src/LazyImage.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ const _LazyImage = css`
6666
--sf_px: min(var(--x_sf_px), var(--y_sf_px));
6767
width: calc((var(--width) * var(--sf_px) / 100));
6868
height: calc((var(--height) * var(--sf_px) / 100));
69-
max-width: calc(var(--width) * 1px);
70-
max-height: calc(var(--height) * 1px);
7169
7270
${breakpoint("xs")} {
7371
object-fit: cover !important;

src/articles/2024-04-28-deploying-a-solid-start-app-to-github-pages/article.mdx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,9 @@ caption="The workflow finished successfully"
215215
/>
216216

217217
Let's try opening the page and ensuring everything works as it should.
218+
Also check for any errors in the console and try clicking the button to increase the counter.
219+
If the counter works, it means that JS hydrated successfully and client side Javascript works
220+
as expected.
218221

219222
<Img
220223
src={p3}

0 commit comments

Comments
 (0)