Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting elements with the same selector (without on) #620

Closed
chopfitzroy opened this issue Oct 15, 2019 · 8 comments
Closed

Highlighting elements with the same selector (without on) #620

chopfitzroy opened this issue Oct 15, 2019 · 8 comments
Labels

Comments

@chopfitzroy
Copy link

This issue is related to #525 but different.

I have a situation where I have a side menu on desktop and a top header on mobile (different markup and shown/hidden with media queries) but the tooltip for them is the same.

Is it possible to when using the modal overlay and omitting the on parameter to highlight all elements that have the specified selector, that way if you had to elements that did the same thing on the screen at the same time it would still make sense and it would be perfect for situations where you have different semantics on Desktop/Mobile.

Cheers!

@RobbieTheWagner
Copy link
Member

@CrashyBang you would not be showing the desktop and mobile views at the same time though right?

@chopfitzroy
Copy link
Author

Hey @rwwagner90

Yes in my case I would only ever be showing/highlighting one element at a time.

Cheers.

@RobbieTheWagner
Copy link
Member

@CrashyBang are you showing the user the desktop and mobile view for the tour? I am confused how there are two elements you need to highlight for this case.

@chopfitzroy
Copy link
Author

chopfitzroy commented Oct 20, 2019

I want to show the tour on both, essentially I have two different elements that serve the same purpose and will use the same tour step a "header" on mobile and a "side menu" on desktop.

So in an ideal world it would highlight both elements for the step (of course there is only either one on the screen at any given time).

However it shouldn't really matter if there are multiple on the screen at the same time, i.e if I had two buttons that did the same thing on the screen at the same time I wouldn't be opposed to both being highlighted (but this isn't my use case this is just food for thought).

@RobbieTheWagner
Copy link
Member

@CrashyBang could you not give them each the same selector?

@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 20, 2019
@chopfitzroy
Copy link
Author

Hey @rwwagner90

Sorry haven't looked at this in a while, as soon as I am back on that project I will take a look.

Cheers,
Otis.

@stale stale bot removed the wontfix label Nov 20, 2019
@stale
Copy link

stale bot commented Dec 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 20, 2019
@stale stale bot closed this as completed Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants