Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box/Rectangle overlay on the image to have a better idea of mask size before creating the mask #48

Open
4 of 5 tasks
4rnaudB opened this issue May 27, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@4rnaudB
Copy link
Member

4rnaudB commented May 27, 2022

Checklist

  • I've given this issue a self-descriptive, meaningful title (e.g. Implement optimization algorithms for shimming)
  • I've described the new feature and its expected behaviour
  • I've described the usage scenario for the new feature
  • (optional) I've added some ideas about how to implement my suggestion
  • I've given this issue the correct labels

Feature Description:

Add a button or use the size button to make a mask preview appears on the screen. You could then modify the mask size the same way you modify an image size on word for example. The current mask size could appear in the size text boxes.

Implementation Suggestion:

Add a function to the size button where it activates/deactivates the mask preview

Additional Context / Screenshots:

@4rnaudB 4rnaudB added the enhancement New feature or request label May 27, 2022
@jcohenadad
Copy link
Member

@4rnaudB i'm not sure i understand this feature. There is already a "preview" button in the FSLeyes GUI to display/hide an image.

Maybe you could do a quick drawing (with screenshot from FSLeyes window) showing what you have in mind? Sometimes a picture is worth a thousand words

@jcohenadad
Copy link
Member

jcohenadad commented May 27, 2022

Also, in general, I would try to minimize the production of code that duplicates with FSLeyes' existing features. Eg, FSLeyes already has an extensive masking toolkit:

image

Instead, I would suggest to add documentation that explains how users can leverage these features.

@4rnaudB
Copy link
Member Author

4rnaudB commented May 27, 2022

I'm not fully familiar with shimming-toolbox yet so there might be the feature somewhere already, but I was thinking in this image:
image
I would like to be able to modify manually the mask size by dragging the white rectangle just like you change a picture size in word. The current mask size could be displayed in the size texte boxes to have a better idea of the size of the mask you want.

@jcohenadad
Copy link
Member

jcohenadad commented May 27, 2022

I'd like us to re-think the whole masking GUI, see #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants