Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable the creation of file for a search #2377

Open
1 task done
officialasishkumar opened this issue Dec 2, 2024 · 4 comments
Open
1 task done

Option to disable the creation of file for a search #2377

officialasishkumar opened this issue Dec 2, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@officialasishkumar
Copy link

Description

a flag that can disable the creation of the txt file created after a successful search would be great.

I would love to work on this if approved.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@officialasishkumar officialasishkumar added the enhancement New feature or request label Dec 2, 2024
@bytexenon
Copy link
Contributor

Looks like this was already taken care of in #2263, -- you can use the --no-txt option for it.
Just a heads up though, it’s only available if you install Sherlock directly from GitHub (git clone https://github.com/sherlock-project/sherlock && cd sherlock && pipx install . --force), since version 0.16.0 isn’t out yet

@officialasishkumar
Copy link
Author

why not make this option default?

@bytexenon
Copy link
Contributor

why not make this option default?

Honestly, I have no idea lol. I think it would've been better to ask one of the maintainers

@ppfeister
Copy link
Member

It will become the default shortly. When it was implemented, we decided to not change the default behavior too soon so as to not break any workflows or automations that depend on it. Bit of an adjustment period.

I don't believe this flag is in the latest release but I'll be pushing a minor update shortly that would include it. Just need to fix my dev environment (bad system update, broke things)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants