Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week 29 : Golang + GitHub Status API + Slack Notifications #40

Open
rominirani opened this issue Jul 15, 2016 · 2 comments
Open

Week 29 : Golang + GitHub Status API + Slack Notifications #40

rominirani opened this issue Jul 15, 2016 · 2 comments
Labels

Comments

@rominirani
Copy link
Contributor

No description provided.

@rominirani
Copy link
Contributor Author

Please provide your feedback by posting a comment against this issue.

@nosequeldeebee
Copy link

This is a great post. I've really enjoyed experimenting with the Slack webhook. Some feedback:

In your raise function: other than for readability, I don't see an advantage to declaring separate variables for WebhookURL and postParams when SlackIncomingWebhookURL can simply be used in http.PostForm and Sprintf can be used when json.Marshal-ing the SlackMessage.

Also, is there a reason you've declared so many variables and constants globally? In my version of the program I moved the githubStatus declaration inside main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants