Preserve background task notifications after end_turn#57
Closed
Gujiassh wants to merge 1 commit intoshareAI-lab:mainfrom
Closed
Preserve background task notifications after end_turn#57Gujiassh wants to merge 1 commit intoshareAI-lab:mainfrom
Gujiassh wants to merge 1 commit intoshareAI-lab:mainfrom
Conversation
|
@Gujiassh is attempting to deploy a commit to the crazyboym's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
The only visible blocker on this PR right now looks like the Vercel team authorization check, rather than a code/test regression. If preview deploys matter here, someone on the team will need to authorize it; otherwise I’m happy for maintainers to ignore that status and review the patch on its own merits. |
Contributor
|
This PR reintroduces hardcoded assistant ack messages ('Noted background results.') that were removed in PR #118 to fix 400 errors with Claude 4.6. The core waiting logic is sound but needs rebasing against current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
s08_background_tasks.pyloop alive until background task results are delivered instead of exiting immediately onend_turns_full.pyso the capstone agent does not drop background completions eitherTesting
python3 -m unittest tests/test_background_notifications.py -vpython3 -m py_compile agents/s08_background_tasks.py agents/s_full.py tests/test_background_notifications.pyCloses #46