tests

Author: nicklog

composer.json

@@ -67,7 +67,8 @@
         "maglnet/composer-require-checker": "^2.0",
         "phpunit/phpunit": "^8.4",
         "symfony/var-dumper": "^4.3",
-        "icanhazstring/composer-unused": "^0.6.2"
+        "icanhazstring/composer-unused": "^0.6.2",
+        "dg/bypass-finals": "^1.1"
     },
     "suggest": {
         "shapecode/cron-sonata-admin-bundle": "to manage cronjobs in the sonata admin panel"

composer.lock

@@ -25,27 +25,21 @@ Add the bundle to your project through composer:
 composer require shapecode/cron-bundle
 ```
 
-Add the bundle to your application kernel:
+Add the bundle to your config if it flex did not do it for you:
 ```php
 <?php
 
-// application/ApplicationKernel.php
-public function registerBundles()
-{
-	// ...
-	$bundles = array(
-	    // ...
-            new Shapecode\Bundle\CronBundle\ShapecodeCronBundle(),
-	);
+// config/bundles.php
+return [
     // ...
-
-    return $bundles;
-}
+    Shapecode\Bundle\CronBundle\ShapecodeCronBundle::class,
+    // ...
+];
 ```
 
 Update your DB schema ...
 
-... with Doctrine standard method ...
+... with Doctrine schema update method ...
 ```bash
 php bin/console doctrine:schema:update --force
 ```
@@ -58,6 +52,8 @@ Creating your own tasks with CronBundle couldn't be easier - all you have to do
 ```php
 <?php
 
+declare(strict_types=1);
+
 namespace App\DemoBundle\Command;
 
 use Shapecode\Bundle\CronBundle\Annotation\CronJob;
@@ -66,29 +62,19 @@ use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
 /**
- * Class DemoCommand
- * @package App\DemoBundle\Command
- * @author Nikita Loges
- *
  * @CronJob("*\/5 * * * *")
  * Will be executed every 5 minutes
  */
 class DemoCommand extends Command
 {
 
-    /**
-     * @inheritdoc
-     */
-    public function configure()
+    public function configure() : void
     {
 		// Must have a name configured
 		// ...
     }
 
-    /**
-     * @inheritdoc
-     */
-    public function execute(InputInterface $input, OutputInterface $output)
+    public function execute(InputInterface $input, OutputInterface $output) : void
     {
 		// Your code here
     }

docs/README.md

@@ -1,9 +1,5 @@
 parameters:
 	ignoreErrors:
-		-
-			message: "#^Variable method call on Shapecode\\\\Bundle\\\\CronBundle\\\\Console\\\\Style\\\\CronStyle\\.$#"
-			count: 1
-			path: src/Command/CronProcessCommand.php
 
 		-
 			message: "#^Method Symfony\\\\Contracts\\\\EventDispatcher\\\\EventDispatcherInterface\\:\\:dispatch\\(\\) invoked with 2 parameters, 1 required\\.$#"
@@ -15,11 +11,6 @@ parameters:
 			count: 3
 			path: src/CronJob/GenericCleanUpHourlyCommand.php
 
-		-
-			message: "#^Class Shapecode\\\\Bundle\\\\CronBundle\\\\Event\\\\GenericCleanUpEvent extends deprecated class Symfony\\\\Component\\\\EventDispatcher\\\\Event\\:\nsince Symfony 4\\.3, use \"Symfony\\\\Contracts\\\\EventDispatcher\\\\Event\" instead$#"
-			count: 1
-			path: src/Event/GenericCleanUpEvent.php
-
 		-
 			message: "#^Method Symfony\\\\Contracts\\\\EventDispatcher\\\\EventDispatcherInterface\\:\\:dispatch\\(\\) invoked with 2 parameters, 1 required\\.$#"
 			count: 1

phpstan-baseline.neon

@@ -5,11 +5,8 @@
          xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.8/phpunit.xsd"
          backupGlobals="false"
          colors="true"
-         processIsolation="false">
-    <php>
-        <ini name="error_reporting" value="-1"/>
-        <server name="KERNEL_CLASS" value="AppKernel"/>
-    </php>
+         processIsolation="false"
+         bootstrap="tests/bootstrap.php">
 
     <testsuites>
         <testsuite name="default">

phpunit.xml.dist

@@ -16,7 +16,9 @@
 use Symfony\Component\Stopwatch\Stopwatch;
 use Throwable;
 use function get_class;
+use function is_callable;
 use function number_format;
+use function sprintf;
 use function str_replace;
 
 final class CronProcessCommand extends BaseCommand
@@ -92,7 +94,14 @@ protected function execute(InputInterface $input, OutputInterface $output) : int
         }
 
         $duration = $this->getStopWatch()->getEvent($watch)->getDuration();
-        $style->{$block}($statusStr . ' in ' . number_format(($duration / 1000), 4) . ' seconds');
+
+        $seconds = $duration > 0 ? number_format(($duration / 1000), 4) : 0;
+        $message = sprintf('%s in %s seconds', $statusStr, $seconds);
+
+        $callback = [$style, $block];
+        if (is_callable($callback)) {
+            $callback($message);
+        }
 
         // Record the result
         $this->recordJobResult($job, $duration, $jobOutput, $statusCode);