Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT: Fix get_confint() and confint() and assertion checking #57

Open
7 tasks
shamindras opened this issue Mar 27, 2021 · 0 comments
Open
7 tasks

FT: Fix get_confint() and confint() and assertion checking #57

shamindras opened this issue Mar 27, 2021 · 0 comments
Labels
feature a feature request or enhancement

Comments

@shamindras
Copy link
Owner

shamindras commented Mar 27, 2021

This is to be done after #55 is fully completed and merged in #56 .

get_confint() and confint() related

  • Write prototype of get_confint() tibble with pivot_longer() working with the confidence level. Ensure that this is a valid tidy format for this table. Only conf.low and conf.high have the level parameter as not an NA value
  • Get prototype of get_confint() tibble with pivot_wider() working with the confidence level
  • Fix get_confint() to return conf.low/conf.high return levels
  • Fix confint to use get_confint() and group_split as discussed [here](https://maarshq.slack.com/archives/D01JL7EAW64/p1615811868000700?thread_ts=1615777275.013500&cid=D01JL
  • Fix confint to print levels

Assertion Checking

  • @shamindras : Fix assertion handling for lm only, maars_lm, maars_glm, glm only. This will replace code like this
  • Do assertion handling for missing parameters e.g. running just lm_fit %>% maars::comp_var() with no parameters, and handle this elegantly
@shamindras shamindras added the feature a feature request or enhancement label Mar 27, 2021
@shamindras shamindras changed the title FT: Fix confint FT: Fix get_confint() and confint() Mar 27, 2021
@shamindras shamindras changed the title FT: Fix get_confint() and confint() FT: Fix get_confint() and confint() and assertion checking Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant