Skip to content

Commit c470c12

Browse files
ihabadhamclaude
andcommitted
Remove redundant buffer size validation method
The concurrent_component_streaming_buffer_size setter already validates the value when assigned (lines 91-97), making the separate validation method unnecessary. This was identified in code review as duplicate logic. The setter is called during initialization (line 136) and any subsequent assignments, providing complete validation coverage. Removing the duplicate validation method simplifies the codebase without changing behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 1447fa7 commit c470c12

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

react_on_rails_pro/lib/react_on_rails_pro/configuration.rb

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ def setup_config_values
142142
validate_remote_bundle_cache_adapter
143143
setup_renderer_password
144144
setup_assets_to_copy
145-
validate_concurrent_component_streaming_buffer_size
146145
setup_execjs_profiler_if_needed
147146
check_react_on_rails_support_for_rsc
148147
end
@@ -234,14 +233,6 @@ def validate_remote_bundle_cache_adapter
234233
end
235234
end
236235

237-
def validate_concurrent_component_streaming_buffer_size
238-
return if concurrent_component_streaming_buffer_size.is_a?(Integer) &&
239-
concurrent_component_streaming_buffer_size.positive?
240-
241-
raise ReactOnRailsPro::Error,
242-
"config.concurrent_component_streaming_buffer_size must be a positive integer"
243-
end
244-
245236
def setup_renderer_password
246237
return if renderer_password.present?
247238

0 commit comments

Comments
 (0)