Skip to content

Commit b958b05

Browse files
justin808claude
andcommitted
Fix CI failure by skipping version validation during generator runtime
The strict version validation added in #1881 runs during Rails initialization via an after_initialize hook. However, when running `rails generate react_on_rails:install`, the npm packages haven't been installed yet, causing the validation to fail with: "No React on Rails npm package is installed." This fix adds a check to skip validation when running Rails generators (detected by checking if ARGV.first is "generate" or "g"). The generator will install packages during its execution, so validation at initialization time is not appropriate. This allows CI to successfully run example generation tasks without errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 5186da7 commit b958b05

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

lib/react_on_rails/engine.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,14 @@ module ReactOnRails
66
class Engine < ::Rails::Engine
77
# Validate package versions and compatibility on Rails startup
88
# This ensures the application fails fast if versions don't match or packages are misconfigured
9+
# Skip validation during generator runtime since packages may not be installed yet
910
initializer "react_on_rails.validate_version_and_package_compatibility" do
1011
config.after_initialize do
12+
# Skip validation when running Rails generators - they will install packages during execution
13+
# Check if we're in a generator context by looking at the command being run
14+
running_generator = ARGV.first == "generate" || ARGV.first == "g"
15+
next if running_generator
16+
1117
Rails.logger.info "[React on Rails] Validating package version and compatibility..."
1218
VersionChecker.build.validate_version_and_package_compatibility!
1319
Rails.logger.info "[React on Rails] Package validation successful"

0 commit comments

Comments
 (0)