Skip to content

Commit b65c6ec

Browse files
author
sg
committed
random fixes
1 parent 0ca82d3 commit b65c6ec

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

.github/workflows/cdk-deploy.yml .github/workflows/cdk-deploy-dev.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Manually Deploy a CDK stack with OIDC
1+
name: Deploy a CDK stack to dev env with OIDC
22

33
on:
44
workflow_dispatch:

.gitignore

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
*.js
1+
.*.js
22
!jest.config.js
33
*.d.ts
44
node_modules

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,19 @@ These instructions will get you a copy of this project up and running in your ow
1313
- Create a repo for this project.
1414
- Setup Github environments and secrets in the repo you just created. Use SECRETS, not variables.
1515
- Add repositories you want to grant deployment permissions to the `github-actions-role-stack.ts` file.
16-
- Bootstrap the project with cdk deploy --all.
16+
- Bootstrap the project with cdk deploy --all for every aws account you plan to deploy to.
1717
- Configure the actions workflow to suit your needs.
1818
- Add new projects to the `github-actions-role-stack.ts` file as needed.
1919

2020
### Setup Github Environments and Secrets
2121

2222
1. Create an environment in your Github repository settings.
23-
- Name the environment based on where it is deploying. (ie prod, dev, staging, etc based on your needs.)
23+
- Name the environment based on where it is deploying. (ie prod, dev, staging, etc. based on your needs.)
2424
- The default is the main branch is prod.
2525
2. Create secret variables in each Github environment you are deploying too. USE SECRETS, NOT variables.
2626
- `AWS_ACCOUNT_ID`: The AWS account ID where the CDK application will be deployed. (Your AWS account number)
2727
- `AWS_REGION`: The AWS region where the CDK application will be deployed. (us-east-1)
28-
- `ENVIRONMENT`: The name of the deployment environment. Default is main branch is prod. (ie prod, dev, staging, etc)
28+
- `ENVIRONMENT`: The name of the deployment environment. Default is main branch is prod. (ie prod, dev, staging, etc.)
2929

3030
### Add Repositories you want to grant deployment permissions to
3131

0 commit comments

Comments
 (0)