Skip to content

Commit fb35b5c

Browse files
committed
Remove coroutine related code.
1 parent ef060b9 commit fb35b5c

21 files changed

+155
-858
lines changed

CMakeLists.txt

+3-34
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,11 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_BINARY_DIR}")
33
message(FATAL_ERROR "In-source builds are not allowed.")
44
endif("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_BINARY_DIR}")
55

6+
cmake_minimum_required(VERSION 3.19)
7+
68
project(ermia)
7-
cmake_minimum_required(VERSION 2.8)
89

9-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++14 -fcoroutines-ts -stdlib=libc++ -Woverloaded-virtual -Werror=reorder -Wno-address-of-packed-member")
10+
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++14 -stdlib=libc++ -Woverloaded-virtual -Werror=reorder -Wno-address-of-packed-member")
1011
set(LINK_FLAGS "-lc++abi -libverbs -lnuma -lpthread -pthread -lrt -lglog -lgflags")
1112
link_libraries(${LINK_FLAGS})
1213

@@ -68,38 +69,6 @@ add_library(ermia_si SHARED ${LIB_ERMIA_SRC})
6869
add_executable(ermia_SI ${CMAKE_CURRENT_SOURCE_DIR}/benchmarks/dbtest.cc)
6970
target_link_libraries(ermia_SI ermia_si thread_pool)
7071

71-
# SI with coroutine
72-
#add_library(ermia_coro_si SHARED ${LIB_ERMIA_SRC})
73-
#set_target_properties(ermia_coro_si PROPERTIES COMPILE_FLAGS "-DADV_COROUTINE")
74-
75-
#add_executable(ermia_coro_SI ${CMAKE_CURRENT_SOURCE_DIR}/benchmarks/dbtest.cc)
76-
#set_target_properties(ermia_coro_SI PROPERTIES COMPILE_FLAGS "-DADV_COROUTINE")
77-
#target_link_libraries(ermia_coro_SI ermia_coro_si thread_pool)
78-
79-
# SI+SSN
80-
#add_library(ermia_si_ssn SHARED ${LIB_ERMIA_SRC})
81-
#set_target_properties(ermia_si_ssn PROPERTIES COMPILE_FLAGS "-DSSN -DEARLY_SSN_CHECK")
82-
83-
#add_executable(ermia_SI_SSN ${CMAKE_CURRENT_SOURCE_DIR}/benchmarks/dbtest.cc)
84-
#set_target_properties(ermia_SI_SSN PROPERTIES COMPILE_FLAGS "-DSSN -DEARLY_SSN_CHECK")
85-
#target_link_libraries(ermia_SI_SSN ermia_si_ssn thread_pool)
86-
87-
# SSI
88-
#add_library(ermia_ssi SHARED ${LIB_ERMIA_SRC})
89-
#set_target_properties(ermia_ssi PROPERTIES COMPILE_FLAGS "-DSSI")
90-
91-
#add_executable(ermia_SSI ${CMAKE_CURRENT_SOURCE_DIR}/benchmarks/dbtest.cc)
92-
#set_target_properties(ermia_SSI PROPERTIES COMPILE_FLAGS "-DSSI")
93-
#target_link_libraries(ermia_SSI ermia_ssi thread_pool)
94-
95-
# MVOCC
96-
#add_library(ermia_mvocc SHARED ${LIB_ERMIA_SRC})
97-
#set_target_properties(ermia_mvocc PROPERTIES COMPILE_FLAGS "-DMVOCC")
98-
99-
#add_executable(ermia_MVOCC ${CMAKE_CURRENT_SOURCE_DIR}/benchmarks/dbtest.cc)
100-
#set_target_properties(ermia_MVOCC PROPERTIES COMPILE_FLAGS "-DMVOCC")
101-
#target_link_libraries(ermia_MVOCC ermia_mvocc thread_pool)
102-
10372
# Benchmark scripts
10473
file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/benchmarks/run.sh" DESTINATION ${CMAKE_BINARY_DIR})
10574
file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/benchmarks/run2.sh" DESTINATION ${CMAKE_BINARY_DIR})

benchmarks/bench.cc

-3
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,6 @@ bool bench_worker::finish_workload(rc_t ret, uint32_t workload_idx, util::timer
128128
}
129129

130130
void bench_worker::MyWork(char *) {
131-
// Only used for coroutine execution
132-
ermia::dia::coro_task_private::memory_pool memory_pool;
133-
134131
if (is_worker) {
135132
workload = get_workload();
136133
txn_counts.resize(workload.size());

benchmarks/bench.h

+2-9
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
#include "../ermia.h"
99
#include "../util.h"
1010
#include "../dbcore/sm-log-alloc.h"
11-
#include "../dbcore/sm-coroutine.h"
1211

1312
extern void ycsb_do_test(ermia::Engine *db, int argc, char **argv);
1413
extern void ycsb_cs_advance_do_test(ermia::Engine *db, int argc, char **argv);
@@ -120,22 +119,16 @@ class bench_worker : public ermia::thread::Runner {
120119

121120
/* For 'normal' workload (r/w on primary, r/o on backups) */
122121
typedef rc_t (*txn_fn_t)(bench_worker *);
123-
typedef std::experimental::coroutine_handle<ermia::dia::generator<bool>::promise_type> SimpleCoroHandle;
124-
typedef SimpleCoroHandle (*coro_txn_fn_t)(bench_worker *, uint32_t);
125-
typedef ermia::dia::task<rc_t> (*task_fn_t)(bench_worker *, uint32_t, ermia::epoch_num);
126122
struct workload_desc {
127123
workload_desc() {}
128-
workload_desc(const std::string &name, double frequency, txn_fn_t fn,
129-
coro_txn_fn_t cf=nullptr, task_fn_t tf=nullptr)
130-
: name(name), frequency(frequency), fn(fn), task_fn(tf), coro_fn(cf) {
124+
workload_desc(const std::string &name, double frequency, txn_fn_t fn)
125+
: name(name), frequency(frequency), fn(fn) {
131126
ALWAYS_ASSERT(frequency > 0.0);
132127
ALWAYS_ASSERT(frequency <= 1.0);
133128
}
134129
std::string name;
135130
double frequency;
136131
txn_fn_t fn;
137-
task_fn_t task_fn;
138-
coro_txn_fn_t coro_fn;
139132
};
140133
typedef std::vector<workload_desc> workload_desc_vec;
141134
virtual workload_desc_vec get_workload() const = 0;

dbcore/CMakeLists.txt

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ set(DBCORE_SRC
2020
${CMAKE_CURRENT_SOURCE_DIR}/sm-cmd-log.cpp
2121
${CMAKE_CURRENT_SOURCE_DIR}/sm-common.cpp
2222
${CMAKE_CURRENT_SOURCE_DIR}/sm-config.cpp
23-
${CMAKE_CURRENT_SOURCE_DIR}/sm-coroutine.cpp
2423
${CMAKE_CURRENT_SOURCE_DIR}/sm-exceptions.cpp
2524
${CMAKE_CURRENT_SOURCE_DIR}/sm-table.cpp
2625
${CMAKE_CURRENT_SOURCE_DIR}/sm-log-alloc.cpp

dbcore/sm-coroutine.cpp

-15
This file was deleted.

0 commit comments

Comments
 (0)