-
Notifications
You must be signed in to change notification settings - Fork 521
Make error::Kind public #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Make error::Kind public #1185
Conversation
|
Also made it here #1138 with a few test cases but it seems like it won't be merge any time soon.. |
|
This is something I also would love, I've just ended up doing |
| ToSql(usize), | ||
| FromSql(usize), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These usizes are very ambiguous. Is this the index of the column? We should document it.
EDIT: or even convert it into something along the lines of:
FromSql {
column_index: usize,
}Co-authored-by: Paolo Barbolini <[email protected]>
Co-authored-by: Paolo Barbolini <[email protected]>
Make
error::Kindpublic and provide a getter. This allows lib/app code to handle different kind of errors, e.g.I documented errors I know about, but the ones I don't know what they do I left undocumented, hiding the doc warning.