Skip to content

Conversation

@levkk
Copy link
Contributor

@levkk levkk commented Nov 1, 2024

Make error::Kind public and provide a getter. This allows lib/app code to handle different kind of errors, e.g.

match err.kind() {
    Kind::Column(name) => panic!("You forgot to include column {} into the query", name),
    Kind::Parameter(_, _) => panic!("You forgot to pass a parameter to the prepared statement"),
    kind => panic!("{:?}", kind),
}

I documented errors I know about, but the ones I don't know what they do I left undocumented, hiding the doc warning.

@BaptisteRoseau
Copy link

Also made it here #1138 with a few test cases but it seems like it won't be merge any time soon..

@Aceeri
Copy link

Aceeri commented Dec 11, 2024

This is something I also would love, I've just ended up doing err.to_string() and re-parsing it which is pretty counterproductive.

Comment on lines 347 to 348
ToSql(usize),
FromSql(usize),
Copy link
Member

@paolobarbolini paolobarbolini Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These usizes are very ambiguous. Is this the index of the column? We should document it.

EDIT: or even convert it into something along the lines of:

FromSql {
    column_index: usize,
}

levkk and others added 2 commits September 20, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants