Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error::Kind public #1185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

levkk
Copy link
Contributor

@levkk levkk commented Nov 1, 2024

Make error::Kind public and provide a getter. This allows lib/app code to handle different kind of errors, e.g.

match err.kind() {
    Kind::Column(name) => panic!("You forgot to include column {} into the query", name),
    Kind::Parameter(_, _) => panic!("You forgot to pass a parameter to the prepared statement"),
    kind => panic!("{:?}", kind),
}

I documented errors I know about, but the ones I don't know what they do I left undocumented, hiding the doc warning.

@BaptisteRoseau
Copy link

Also made it here #1138 with a few test cases but it seems like it won't be merge any time soon..

@Aceeri
Copy link

Aceeri commented Dec 11, 2024

This is something I also would love, I've just ended up doing err.to_string() and re-parsing it which is pretty counterproductive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants