Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

built-in tracing support #642

Open
jbg opened this issue Jul 31, 2020 · 2 comments · May be fixed by #1053
Open

built-in tracing support #642

jbg opened this issue Jul 31, 2020 · 2 comments · May be fixed by #1053

Comments

@jbg
Copy link

jbg commented Jul 31, 2020

Is there any interest in built-in tracing (formerly tokio-trace) support? I'm looking at how to instrument the queries my application (which is already using tracing) makes and without built-in support in rust-postgres I will need to construct wrappers and modify deadpool to return those wrappers, which gets a bit untidy.
@sfackler
Copy link
Owner

Sure, I'd be happy to take a PR!

@ar3s3ru
Copy link

ar3s3ru commented Aug 15, 2020

I'd love that too! You could put the wrappers behind a feature flag that is not enabled by default, so deadpool doesn't "break" and users uninterested in the traces can just opt-out of the dependency.

@hlinnaka hlinnaka mentioned this issue Jan 24, 2023
Closed
@Protryon Protryon linked a pull request Jul 24, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tracing support Protryon/rust-postgres
3 participants
@jbg @sfackler @ar3s3ru