servo: Allow configuring style stack size #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running Servo with ASAN we hit the stack limit. We can use compile-time parsing of environment variables, to allow the embedder to configure the style thread stack size.
mrobinson
reviewed
Nov 17, 2025
Comment on lines
+40
to
+51
| pub const STYLE_THREAD_STACK_SIZE_KB: usize = const { | ||
| let default_stack_size = 512; | ||
| if let Some(user_def_size) = option_env!("SERVO_STYLE_THREAD_STACK_SIZE_KB") { | ||
| if let Ok(user_def_size) = usize::from_str_radix(user_def_size, 10) { | ||
| user_def_size | ||
| } else { | ||
| panic!("SERVO_STYLE_THREAD_STACK_SIZE_KB must be a valid integer") | ||
| } | ||
| } else { | ||
| default_stack_size | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
Would it be possible to make this a bit simpler and just increase the stack size when ASAN is enabled?
Member
There was a problem hiding this comment.
Given servo/servo#40814 I would also like to do this for debug builds, if possible.
Member
Author
There was a problem hiding this comment.
I would prefer keeping it configurable too, since it allows embedders to adjust the stack size based on their needs.
The code is quite simple, just very verbose since we can't use any traits in const contexts, like and_then() or unwrap_or().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Servo with ASAN we hit the stack limit. We can use compile-time parsing of environment variables, to allow the embedder to configure the style thread stack size.
Fixes #223