Replace ArgumentValidator.EnsureArgumentNotNull() by ArgumentNullException.ThrowIfNull() (#264)

* Replace `ArgumentValidator.EnsureArgumentNotNull()` by `ArgumentNullException.ThrowIfNull()`

* Avoid quoted

* Avoid nameof

Author: SergeiPavlov

Orm/Xtensive.Orm.Tests.Core/Modelling/IndexingModel/TypeInfo.cs

@@ -188,7 +188,7 @@ public TypeInfo(Type type, int length, int scale, int precision)
 
     public TypeInfo(Type type, bool isNullable)
     {
-      ArgumentValidator.EnsureArgumentNotNull(type, "type");
+      ArgumentNullException.ThrowIfNull(type);
       if (isNullable && type.IsValueType && !type.IsNullable())
         ArgumentValidator.EnsureArgumentIsInRange(true, false, false, "isNullable");
       Type = type;
@@ -205,7 +205,7 @@ public TypeInfo(Type type, bool isNullable, int length)
     public TypeInfo(Type type, bool isNullable, int length, CultureInfo culture)
       : this(type, isNullable, length)
     {
-      ArgumentValidator.EnsureArgumentNotNull(culture, "culture");
+      ArgumentNullException.ThrowIfNull(culture);
       Culture = culture;
     }
 
@@ -216,4 +216,4 @@ public TypeInfo(Type type, bool isNullable, int length, int scale, int precision
       Precision = precision;
     }
   }
-}
+}

Orm/Xtensive.Orm.Tests.Core/Reflection/DelegateHelperCreateDelegateTest.cs

@@ -132,7 +132,7 @@ private static void LogicTest(Type[] types, object callTarget, Type type, string
 
     public static IEnumerable<TItem> Reverse<TItem>(IList<TItem> list)
     {
-      ArgumentValidator.EnsureArgumentNotNull(list, "list");
+      ArgumentNullException.ThrowIfNull(list);
       for (int i = list.Count-1; i>=0; i--)
         yield return list[i];
     }

Orm/Xtensive.Orm.Tests.Core/Tuples/DummyTuple.cs

@@ -81,7 +81,7 @@ public override void SetValue(int fieldIndex, object fieldValue)
 
     public DummyTuple(TupleDescriptor descriptor)
     {
-      ArgumentValidator.EnsureArgumentNotNull(descriptor, "descriptor");
+      ArgumentNullException.ThrowIfNull(descriptor);
       this.descriptor = descriptor;
       values = new object[descriptor.Count];
       available = new BitArray(new bool[descriptor.Count]);

Orm/Xtensive.Orm.Tests.Framework/Internals/InstanceGeneratorBase.cs

@@ -64,7 +64,7 @@ IEnumerable IInstanceGeneratorBase.GetInstances(Random random, int? count)
     /// <param name="provider">Instance generator provider this generator is bound to.</param>
     public InstanceGeneratorBase(IInstanceGeneratorProvider provider)
     {
-      ArgumentValidator.EnsureArgumentNotNull(provider, "provider");
+      ArgumentNullException.ThrowIfNull(provider);
       this.provider = provider;
     }
 

Orm/Xtensive.Orm.Tests.Framework/TestSqlDriver.cs

@@ -18,7 +18,7 @@ public static class TestSqlDriver
 
     public static SqlDriver Create(UrlInfo connectionUrl)
     {
-      ArgumentValidator.EnsureArgumentNotNull(connectionUrl, "connectionUrl");
+      ArgumentNullException.ThrowIfNull(connectionUrl);
       return BuildDriver(new ConnectionInfo(connectionUrl));
     }
 
@@ -37,7 +37,7 @@ public static SqlDriver Create(string provider, string connectionString)
 
     public static SqlDriver Create(ConnectionInfo connectionInfo)
     {
-      ArgumentValidator.EnsureArgumentNotNull(connectionInfo, "connectionInfo");
+      ArgumentNullException.ThrowIfNull(connectionInfo);
       return BuildDriver(connectionInfo);
     }
 

Orm/Xtensive.Orm.Tests/Linq/FullTextColumnsDeclarationTest.cs

@@ -104,7 +104,7 @@ private void RunQuery<T>(Expression<Func<T, object>>[] columns)
     private Expression<Func<T, object>>[] MakeUpColumns<T>(Expression<Func<T, object>> column, params Expression<Func<T, object>>[] additionalColumns)
       where T : Entity
     {
-      ArgumentValidator.EnsureArgumentNotNull(column, "column");
+      ArgumentNullException.ThrowIfNull(column);
       var columns = new List<Expression<Func<T, object>>>();
       columns.Add(column);
       if (additionalColumns!=null) {

Orm/Xtensive.Orm/Arithmetic/ArithmeticBase.cs

@@ -117,7 +117,7 @@ public Arithmetic<T> ApplyRules(ArithmeticRules rules)
     /// <param name="rules">Arithmetic rules.</param>
     public ArithmeticBase(IArithmeticProvider provider, ArithmeticRules rules)
     {
-      ArgumentValidator.EnsureArgumentNotNull(provider, "provider");
+      ArgumentNullException.ThrowIfNull(provider);
       this.provider = provider;
       Rules = rules;
       OverflowAllowed = (rules.OverflowBehavior==OverflowBehavior.AllowOverflow);

Orm/Xtensive.Orm/Arithmetic/WrappingArithmetic{T,TBase}.cs

@@ -34,7 +34,7 @@ public abstract class WrappingArithmetic<T, TBase> : ArithmeticBase<T>
     public WrappingArithmetic(IArithmeticProvider provider, ArithmeticRules rules)
       : base(provider, rules)
     {
-      ArgumentValidator.EnsureArgumentNotNull(provider, "provider");
+      ArgumentNullException.ThrowIfNull(provider);
       BaseArithmetic = provider.GetArithmetic<TBase>();
     }
   }

Orm/Xtensive.Orm/Caching/CacheBase.cs

@@ -39,7 +39,7 @@ public abstract class CacheBase<TKey, TItem> : ICache<TKey, TItem>
     /// <inheritdoc/>
     public virtual void Remove(TItem item)
     {
-      ArgumentValidator.EnsureArgumentNotNull(item, "item");
+      ArgumentNullException.ThrowIfNull(item);
       RemoveKey(KeyExtractor(item));
     }
 

Orm/Xtensive.Orm/Caching/FastConcurrentLruCache{TKey, TItem}.cs

@@ -43,7 +43,7 @@ public class FastConcurrentLruCache<TKey, TItem> :
     /// <inheritdoc/>
     public override TItem Add(TItem item, bool replaceIfExists)
     {
-      ArgumentValidator.EnsureArgumentNotNull(item, "item");
+      ArgumentNullException.ThrowIfNull(item);
       var key = KeyExtractor(item);
       if (replaceIfExists) {
         realCache.AddOrUpdate(key, item);