Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the Logo of Layer5 with Service-Mesh-Patterns in config.yml workflow #2

Open
anshgoyalevil opened this issue Apr 12, 2023 · 4 comments · May be fixed by #3
Open

Replace the Logo of Layer5 with Service-Mesh-Patterns in config.yml workflow #2

anshgoyalevil opened this issue Apr 12, 2023 · 4 comments · May be fixed by #3
Assignees
@8rxn

Comments

@anshgoyalevil
Copy link

anshgoyalevil commented Apr 12, 2023 •
edited
Loading

Description

Currently, we are using the Logo of Layer5 instead of SMP. This repository is under the organization SMP, so, there should be the image of SMP.

How to resolve this?

  • Go to .github and replace this welcome image with the new one:

  • Make sure to display the images conditionally, based on the theme selected by user.
    Here's the sample code:

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/w.png">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/b.png">
  <img alt="Meshery Logo" src="">
</picture>

New images are:

Patterns-light
Patterns-dark

  • Download these images, and upload with an appropriate name. Make sure to use conditional rendering as described above.

  • After uploading the image, and removing the previous image, go to .github/config.yml folder and update the reference to previous image to the new image in the following part:

firstPRMergeComment: >
  Thanks for your contribution to the Layer5 and Meshery community! :tada:
   
  ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png)
  &nbsp; &#9; &nbsp; &#9;  &nbsp; &#9;  &nbsp; &#9; :star: Please leave a [star on the project](../stargazers). :smile:

Here, replace ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png) with the code

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/w.png">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/b.png">
  <img alt="Shows a black logo in light color mode and a white one in dark color mode." src="https://user-images.githubusercontent.com/25423296/163456779-a8556205-d0a5-45e2-ac17-42d089e3c3f8.png">
</picture>

make sure to change the image sources with the path to image in the folder where you upload it.

  • That's it.

Contributor Guides and Handbook
@8rxn
Copy link

8rxn commented May 25, 2023

Hey @anshgoyalevil I can do this.

@anshgoyalevil
Copy link
Author

@8rxn Thanks for taking it up. Tagging a maintainer to assign it to you.
// @leecalcote

@leecalcote
Copy link
Member

@8rxn has been showing up strong. I ❤️ it.

@8rxn
Copy link

8rxn commented May 25, 2023

@8rxn has been showing up strong. I ❤️ it.

Thanks @leecalcote 🤠

@8rxn 8rxn linked a pull request May 28, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@8rxn 8rxn

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Welcome Bot config 8rxn/agentless-proxy-app
3 participants
@leecalcote @8rxn @anshgoyalevil