Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validation): import json directly to avoid issues with bundlers #170

Conversation

sudo-alexslater
Copy link

@seriousme
Copy link
Owner

Hi,

the linter errors can probably be fixed by running npm run test as this will automatically run npm run format.

Another problem is that import assert { type: "json"} has been removed from node 22 and later, see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import
Its succesor is import with { type: "json"} however that might not be available on all LTS versions yet.

Kind regards,
Hans

@sudo-alexslater
Copy link
Author

As mentioned in seriousme/fastify-openapi-glue#620 can abandon this PR if we don't think this change is neccesary

@seriousme
Copy link
Owner

Lets close this one.

Thanks for letting me know!

Kind regards,
Hans

@seriousme seriousme closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundled index JS with webpack or esbuild unrunnable
2 participants