Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not Idempotent? #4

Open
orasis opened this issue Feb 16, 2018 · 0 comments
Open

Not Idempotent? #4

orasis opened this issue Feb 16, 2018 · 0 comments

Comments

@orasis
Copy link

orasis commented Feb 16, 2018

I think this approach is not idempotent. If there is a network error on the update request and it goes through anyway you'll end up retrying the update request and update twice. If nothing else you should probably call this out in your docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orasis