Skip to content

Commit 473302d

Browse files
abc3acco
authored andcommitted
refactor: rename boolean functions to follow naming conventions
1 parent 5255dc0 commit 473302d

23 files changed

+71
-71
lines changed

lib/sequin/accounts/impersonate.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ defmodule Sequin.Accounts.Impersonate do
6464
end
6565

6666
defp find_user(user_id) do
67-
if Sequin.String.is_uuid?(user_id) do
67+
if Sequin.String.uuid?(user_id) do
6868
Accounts.get_user(user_id)
6969
else
7070
Accounts.get_user(email: user_id)

lib/sequin/aws/sns.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ defmodule Sequin.Aws.SNS do
3535

3636
def publish_messages(%Client{} = client, topic_arn, messages) do
3737
entries =
38-
if is_fifo?(topic_arn) do
38+
if fifo?(topic_arn) do
3939
Enum.map(messages, fn msg ->
4040
%{
4141
"Id" => Map.fetch!(msg, :message_id),
@@ -117,7 +117,7 @@ defmodule Sequin.Aws.SNS do
117117
Error.service(service: :aws_sns, message: "Error from AWS: #{message} (status=#{status_code})", details: message)}
118118
end
119119

120-
defp is_fifo?(topic_arn) do
120+
defp fifo?(topic_arn) do
121121
String.ends_with?(topic_arn, ".fifo")
122122
end
123123
end

lib/sequin/consumers/function.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ defmodule Sequin.Consumers.Function do
8282
end
8383

8484
def where_id_or_name(query \\ base_query(), id_or_name) do
85-
if Sequin.String.is_uuid?(id_or_name) do
85+
if Sequin.String.uuid?(id_or_name) do
8686
where_id(query, id_or_name)
8787
else
8888
where_name(query, id_or_name)

lib/sequin/consumers/http_endpoint.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ defmodule Sequin.Consumers.HttpEndpoint do
137137
end
138138

139139
def where_id_or_name(query \\ base_query(), id_or_name) do
140-
if Sequin.String.is_uuid?(id_or_name) do
140+
if Sequin.String.uuid?(id_or_name) do
141141
where_id(query, id_or_name)
142142
else
143143
where_name(query, id_or_name)

lib/sequin/consumers/sink_consumer.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ defmodule Sequin.Consumers.SinkConsumer do
297297
end
298298

299299
def where_id_or_name(query \\ base_query(), id_or_name) do
300-
if Sequin.String.is_uuid?(id_or_name) do
300+
if Sequin.String.uuid?(id_or_name) do
301301
where_id(query, id_or_name)
302302
else
303303
where_name(query, id_or_name)

lib/sequin/databases/databases.ex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ defmodule Sequin.Databases do
439439

440440
def test_maybe_replica(%PostgresDatabase{} = db, db_primary) do
441441
cond do
442-
not is_physical_replica?(db) ->
442+
not physical_replica?(db) ->
443443
:ok
444444

445445
is_nil(db_primary) ->
@@ -563,8 +563,8 @@ defmodule Sequin.Databases do
563563
end
564564
end
565565

566-
@spec is_physical_replica?(%PostgresDatabase{}) :: boolean()
567-
def is_physical_replica?(%PostgresDatabase{} = db) do
566+
@spec physical_replica?(%PostgresDatabase{}) :: boolean()
567+
def physical_replica?(%PostgresDatabase{} = db) do
568568
with_uncached_connection(db, fn conn ->
569569
query = """
570570
SELECT pg_is_in_recovery() AS is_physical_replica

lib/sequin/databases/postgres_database.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ defmodule Sequin.Databases.PostgresDatabase do
142142
end
143143

144144
def where_id_or_name(query \\ base_query(), id_or_name) do
145-
if Sequin.String.is_uuid?(id_or_name) do
145+
if Sequin.String.uuid?(id_or_name) do
146146
where_id(query, id_or_name)
147147
else
148148
where_name(query, id_or_name)

lib/sequin/databases/postgres_database_table.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ defmodule Sequin.Databases.PostgresDatabaseTable do
3636
end
3737

3838
def default_group_column_attnums(%__MODULE__{} = table) do
39-
if Postgres.is_event_table?(table) do
39+
if Postgres.event_table?(table) do
4040
Enum.map(["source_database_id", "source_table_oid", "record_pk"], fn col_name ->
4141
column = Sequin.Enum.find!(table.columns, &(&1.name == col_name))
4242
column.attnum

lib/sequin/functions/minielixir.ex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ defmodule Sequin.Functions.MiniElixir do
157157
end
158158

159159
defp ensure_code_is_loaded(id) do
160-
unless is_code_loaded(id) do
160+
unless code_loaded?(id) do
161161
__MODULE__
162162
|> Agent.get_and_update(fn state ->
163163
try do
@@ -179,7 +179,7 @@ defmodule Sequin.Functions.MiniElixir do
179179
module_name_from_id(id)
180180
end
181181

182-
defp is_code_loaded(id) do
182+
defp code_loaded?(id) do
183183
with {:ok, mod} <- module_name_from_id(id),
184184
{:file, _} <- :code.is_loaded(mod) do
185185
true
@@ -189,7 +189,7 @@ defmodule Sequin.Functions.MiniElixir do
189189
end
190190

191191
defp recreate(id) do
192-
with false <- is_code_loaded(id),
192+
with false <- code_loaded?(id),
193193
{:ok, %Function{} = function} <- Consumers.get_function(id) do
194194
create(function.id, function.function.code)
195195
end

lib/sequin/postgres/postgres.ex

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ defmodule Sequin.Postgres do
4242
@doc """
4343
Checks if the given table is an event table by verifying it has all the required columns.
4444
"""
45-
@spec is_event_table?(PostgresDatabaseTable.t()) :: boolean()
46-
def is_event_table?(%PostgresDatabaseTable{} = table) do
45+
@spec event_table?(PostgresDatabaseTable.t()) :: boolean()
46+
def event_table?(%PostgresDatabaseTable{} = table) do
4747
required_column_names = MapSet.new(@event_table_columns, & &1.name)
4848
table_column_names = MapSet.new(table.columns, & &1.name)
4949
MapSet.subset?(required_column_names, table_column_names)
@@ -58,7 +58,7 @@ defmodule Sequin.Postgres do
5858
"""
5959
@spec event_table_version(PostgresDatabaseTable.t()) :: {:ok, :v0 | :"v3.28.25"} | {:error, Error.t()}
6060
def event_table_version(%PostgresDatabaseTable{} = table) do
61-
if is_event_table?(table) do
61+
if event_table?(table) do
6262
has_transaction_annotations = Enum.any?(table.columns, &(&1.name == "transaction_annotations"))
6363
if has_transaction_annotations, do: {:ok, :"v3.28.25"}, else: {:ok, :v0}
6464
else
@@ -269,7 +269,7 @@ defmodule Sequin.Postgres do
269269

270270
# Helper function to cast values using Ecto's type system
271271
def cast_value(value, "uuid") do
272-
if Sequin.String.is_uuid?(value) do
272+
if Sequin.String.uuid?(value) do
273273
Sequin.String.string_to_binary!(value)
274274
else
275275
value

0 commit comments

Comments
 (0)