Bug: minifier doesn't work without assets/vendor

[snayam]

No description provided.

[snayam]

I use asset-mapper but without third-party packages, so i removed the assets/vendor folder. In this case, files are not minified after asset-map:compile.

To work, i have to 2 solutions :

1. Create empty asset/vendor folder, or
2. Set ignore_vendor to false in sensiolabs_minify config

[smnandre]

hi @snayam !
I just pushed a fix and deployed a new version, could you check and tell me if it solves your problem?

[snayam]

Hi @smnandre

I've just tried but same problem :-(

assets/vendor folder present => asset-map:compile -> minifier works fine !
assets/vendor folder not present => asset-map:compile -> minifier doesn't work

In logs, i have the following php debug message, but display in the 2 cases so i don't think it's related :

php.DEBUG: Warning: mkdir(): File exists {"exception":{"Symfony\\Component\\ErrorHandler\\Exception\\SilencedErrorContext":{"severity":2,"file":"/vendor/symfony/asset-mapper/CompiledAssetMapperConfigReader.php","line":43,"trace":[{"file":"/vendor/symfony/asset-mapper/Command/AssetMapperCompileCommand.php","line":78,"function":"saveConfig","class":"Symfony\\Component\\AssetMapper\\CompiledAssetMapperConfigReader","type":"->"}],"count":1}}} []

Symfony 7.1.8 / PHP 8.2.25

[smnandre]

Could you, just to be sure, run this command ?

php bin/console c:c && php bin/console debug:container --tag asset_mapper

assets/vendor folder present => asset-map:compile -> minifier works fine !
assets/vendor folder not present => asset-map:compile -> minifier doesn't work

Same thing, just to be sure, you do clear (bin/console c:p:c --all) and reset assets (rm -rf public/assets) between these tests ?

[snayam]

Could you, just to be sure, run this command ?

php bin/console c:c && php bin/console debug:container --tag asset_mapper

Same thing, just to be sure, you do clear (bin/console c:p:c --all) and reset assets (rm -rf public/assets) between these tests ?

Done but same problem.

I think the issue comes from supports function (MinifierCompiler.php).
Here, $asset->isVendor return true when assets/vendor is present ; false when is not present.

public function supports(MappedAsset $asset): bool
    {
        if (!in_array($asset->publicExtension, $this->extensions, true)) {
            return false;
        }

        if ($this->ignoreVendor && $asset->isVendor) {
            return false;
        }

        foreach ($this->ignorePaths as $ignorePath) {
            if (fnmatch($ignorePath, $asset->sourcePath)) {
                return false;
            }
        }

        return true;
    }

[smnandre]

Here, $asset->isVendor return true when assets/vendor is present ; false when is not present.

For wich asset ? One in particular or all of them ?

[smnandre]

I think this is due to this bug (fixed and released in the next version) .. not something related to this bundle :/

symfony/symfony@9e3984f

[snayam]

Here, $asset->isVendor return true when assets/vendor is present ; false when is not present.

For wich asset ? One in particular or all of them ?

All of them.

I think this is due to this bug (fixed and released in the next version) .. not something related to this bundle :/

symfony/symfony@9e3984f

Yes, it seems that the problem comes more from AssetMapper.

[smnandre]

Did you check if Symfony 7.2 solves your issue @snayam ?