-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLNP-5587] feat: support the reacted user list in supergroup #217
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 11.57% 11.57%
=======================================
Files 356 356
Lines 8390 8389 -1
Branches 2341 2326 -15
=======================================
Hits 971 971
Misses 7343 7343
+ Partials 76 75 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
packages/uikit-react-native/src/components/ChannelMessageList/index.tsx
Outdated
Show resolved
Hide resolved
{userCountDifference > 0 && ( | ||
<View style={styles.pageItem}> | ||
<Text body3 color={select({ dark: palette.onBackgroundDark02, light: palette.onBackgroundLight02 })}> | ||
And {userCountDifference} others |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 string set 하나 추가해주실 수 잇을까요?
packages/uikit-react-native/src/containers/SendbirdUIKitContainer.tsx
Outdated
Show resolved
Hide resolved
REACTION.MORE_USERS 로 추가하였습니다 |
packages/uikit-react-native/src/components/ReactionBottomSheets/ReactionUserListBottomSheet.tsx
Outdated
Show resolved
Hide resolved
packages/uikit-react-native/src/components/ReactionBottomSheets/ReactionUserListBottomSheet.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
CLNP-5587
Description Of Changes
Figma
https://www.figma.com/design/NMDmjvDu3pisIBNTLmhZ6O/WIP_UIKit_Android?node-id=5979-8398&node-type=frame&t=a6sr6Q5ZcIRhy0vd-0
You can test using the app ID “A41EC43B-87A9-40CF-92C5-E178DD0477B1.”
Types Of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply_