Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLNP-5587] feat: support the reacted user list in supergroup #217

Merged
merged 9 commits into from
Nov 21, 2024

Conversation

OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Nov 21, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

CLNP-5587

Description Of Changes

  • Upgraded the “sendbird/chat” package to version 4.16.0.
  • Changed the source of user information from “members” to “sampledUserInfoList” when retrieving users who reacted.
  • Added functionality to display “And {} others” if the number of users who reacted exceeds the visible user list.
  • Updated profile-related processing to handle “SendbirdReactedUserInfo.”
image

Figma
https://www.figma.com/design/NMDmjvDu3pisIBNTLmhZ6O/WIP_UIKit_Android?node-id=5979-8398&node-type=frame&t=a6sr6Q5ZcIRhy0vd-0

You can test using the app ID “A41EC43B-87A9-40CF-92C5-E178DD0477B1.”

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@OnestarLee OnestarLee requested a review from bang9 November 21, 2024 01:17
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 11.57%. Comparing base (b50d6ba) to head (936676a).

Files with missing lines Patch % Lines
...actionBottomSheets/ReactionUserListBottomSheet.tsx 0.00% 7 Missing ⚠️
...components/ReactionAddons/MessageReactionAddon.tsx 0.00% 2 Missing ⚠️
...c/components/GroupChannelMessageRenderer/index.tsx 0.00% 1 Missing ⚠️
...c/components/ThreadParentMessageRenderer/index.tsx 0.00% 1 Missing ⚠️
...uikit-react-native/src/contexts/UserProfileCtx.tsx 0.00% 1 Missing ⚠️
...act-native/src/localization/createBaseStringSet.ts 0.00% 1 Missing ⚠️
packages/uikit-utils/src/sendbird/message.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   11.57%   11.57%           
=======================================
  Files         356      356           
  Lines        8390     8389    -1     
  Branches     2341     2326   -15     
=======================================
  Hits          971      971           
  Misses       7343     7343           
+ Partials       76       75    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@OnestarLee OnestarLee requested review from bang9 and removed request for bang9 November 21, 2024 01:25
{userCountDifference > 0 && (
<View style={styles.pageItem}>
<Text body3 color={select({ dark: palette.onBackgroundDark02, light: palette.onBackgroundLight02 })}>
And {userCountDifference} others
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 string set 하나 추가해주실 수 잇을까요?

@OnestarLee
Copy link
Collaborator Author

OnestarLee commented Nov 21, 2024

{userCountDifference > 0 && (
          <View style={styles.pageItem}>
            <Text body3 color={select({ dark: palette.onBackgroundDark02, light: palette.onBackgroundLight02 })}>
              And {userCountDifference} others
요거 string set 하나 추가해주실 수 잇을까요?

REACTION.MORE_USERS 로 추가하였습니다

Copy link
Collaborator

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OnestarLee OnestarLee added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 44cabe5 Nov 21, 2024
7 checks passed
@OnestarLee OnestarLee deleted the feat/reaction-v2 branch November 21, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants