-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Buddy CI environment variables in README #391
base: master
Are you sure you want to change the base?
Conversation
Revert package-lock.json , update README.md and update buddy.js |
Hi @travi I've resolved the issues mentioned in the review comments. Can you please take another look and let me know if there's anything else needed to get this PR merged? Thank you! |
thanks for the updates @czuli. this is looking good. we'll need to also update the tests that correspond to your code changes. you can reference the existing tests for that file and others to get an idea of how we verify these behaviors. as you can see, the ci workflow currently fails without those updates. could you look into updating those tests as part of this change? keep in mind that you can run |
This PR updates the Buddy CI documentation to reflect the current support for environment variables in Pull Request builds. Buddy now provides the necessary environment variables to determine the source and target branches, enabling accurate detection of
branch
andprBranch
properties byenv-ci
.Changes:
BUDDY_EXECUTION_PULL_REQUEST_HEAD_BRANCH
andBUDDY_EXECUTION_PULL_REQUEST_BASE_BRANCH
.References: