Skip to content
This repository was archived by the owner on Sep 18, 2017. It is now read-only.

Update commit types #12

Open
pensierinmusica opened this issue Mar 10, 2016 · 5 comments
Open

Update commit types #12

pensierinmusica opened this issue Mar 10, 2016 · 5 comments

Comments

@pensierinmusica
Copy link

Hi,

It looks like commit-analyzer should be updated to include all the AngularJS commit message convention style types (i.e. more than only fix, or feat):

  • feat
  • fix
  • docs
  • style
  • refactor
  • perf
  • test
  • chore

Thoughts? Cheers!

@pensierinmusica
Copy link
Author

Hi @boennemann any update on this? Thx!

@pensierinmusica
Copy link
Author

Actually the more I think about it, the more I realize that any code change – if published – should at least bring to a new "patch" version.

Here are some in-depth discussions on the topic:

@hutson
Copy link

hutson commented Apr 7, 2016

As per #11 I think @boennemann should deprecate commit-analyzer and migrate to conventional-recommended-bump.

@ghost
Copy link

ghost commented Mar 26, 2017

What about those who want to create a custom-analyzer? How might they be impacted by this (regardless of how it's implemented)?

@hutson
Copy link

hutson commented Mar 27, 2017

@JHabdas in the case of using conventional-recommended-bump, that depends on how you integrate with it (conventional-recommended-bump takes an argument that specifies which rule set to use (angular, etc).)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants