impose start up constraints between endhosts and their dependencies #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonkr
reviewed
Mar 5, 2024
wonkr
reviewed
Mar 6, 2024
start the endhost containers only after the routers and csservices are up
|
@wonkr Hey, what has become of this ?! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start the endhost containers ('hnode') only after the routers ('rnode') and cs_services ('csnode') and any other infrastructure it depends on are up.
This puts an end to many annoying wait-conditions in container start-scripts especially for scion-endhosts to avoid nasty 'no path to ISD-AS ' errors when they are started before i.e. the border routers.
In order to achieve this the containers X,Y,Z that provide the infrastructure of an Autonomous System hosting a given node N are listed under N's 'depends_on:' section in the docker-compose file.
Currently the type of dependency is 'service-started' but it could be improved to 'service-healthy' if we come up with suitable HEALTHCHECKS for all the different components.
Known potential drawbacks: