Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportScanService not up to date with DefectDojo serializers #6

Open
EndPositive opened this issue Jun 10, 2021 · 0 comments
Open

ImportScanService not up to date with DefectDojo serializers #6

EndPositive opened this issue Jun 10, 2021 · 0 comments

Comments

@EndPositive
Copy link

With secureCodeBox we would like to import generic secureCodeBox findings through DefectDojo's importer API. Currently, we're retrieving the Test Type using TestTypeService. This is however no longer neccessary, as DefectDojo is able to determine the scan type automatically:

The ImportScanSerializer uses the scan_type and ReImportScanSerializer uses test (existing test ID).

This wrapper client, however, does not properly reflect the serializer.

Please take a look at the serializers:

ImportScanSerializer:
https://github.com/DefectDojo/django-DefectDojo/blob/aab58b08e7f309158373e6ab68ec0cf2a8bb5bf7/dojo/api_v2/serializers.py#L1049-L1146

ReImportScanSerializer:
https://github.com/DefectDojo/django-DefectDojo/blob/aab58b08e7f309158373e6ab68ec0cf2a8bb5bf7/dojo/api_v2/serializers.py#L1149-L1224

Once this wrapper is up-to-date with DefectDojo's API, we can update secureCodeBox's persistence-provider for DefectDojo and properly make use of the new secureCodeBox parser #443!

For testing purposes, you can also take a look at how you can import scan results in the UI. It only takes the scan type.

image

If you need any help debugging or testing, let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant