cleanup

Author: mxHuber

CMakeLists.txt

@@ -275,33 +275,7 @@ include(add_nlohmann_json)
 add_nlohmann_json()
 add_json_schema_validator()
 
-# StableCoder cmake-scripts
-# TODO: ask fabian if not release or just equal debug is better
-
-# TODO: add install lcov to bootstrap or something
-#       Do NOT do: sudo apt-get install -y lcov
-#       Apparently this version is insanely old and we need a newer version/the newest version
-#       Installing lcov via the github page + make install has four billion dependencies, so
-#       we need to install those too:
-#       These perl packages include:
-#
-#         - Capture::Tiny
-#         - DateTime
-#         - Devel::Cover
-#         - Digest::MD5
-#         - File::Spec
-#         - at least one flavor of JSON module.
-#           In order of performance/preference:
-#              - JSON::XS
-#              - Cpanel::JSON::XS
-#              - JSON::PP
-#              - JSON
-#         - Memory::Process
-#         - Module::Load::Conditional
-#         - Scalar::Util
-#         - Time::HiRes
-#         - TimeDate
-
+# Coverage
 if ("${CMAKE_BUILD_TYPE}" STREQUAL "Debug" AND CODE_COVERAGE)
   find_program(LLVM_COV_PATH llvm-cov-19)
   message(STATUS "Found llvm-cov ${LLVM_COV_PATH}")

Dockerfile

@@ -18,7 +18,7 @@ RUN --mount=type=bind,source=.,target=/usr/src/phasar,rw \
   cmake -S . -B cmake-build/Release \
     -DCMAKE_BUILD_TYPE=Release \
     -DPHASAR_TARGET_ARCH="" \
-    -DPHASAR_ENABLE_SANITIZERS=OFF \
+    -DPHASAR_ENABLE_SANITIZERS=ON \
     -DBUILD_PHASAR_CLANG=ON \
     -DPHASAR_USE_Z3=ON \
     -DPHASAR_BUILD_UNITTESTS=$RUN_TESTS \

cmake/phasar_macros.cmake

@@ -36,7 +36,7 @@ function(add_phasar_unittest test_name)
   set_tests_properties("${test}" PROPERTIES LABELS "all")
   set(CTEST_OUTPUT_ON_FAILURE ON)
 
-  if ("${CMAKE_BUILD_TYPE}" STREQUAL "Debug" AND CODE_COVERAGE AND NOT PHASAR_DEBUG_LIBDEPS)
+  if ("${CMAKE_BUILD_TYPE}" STREQUAL "Debug" AND CODE_COVERAGE)
     target_code_coverage(${test} AUTO ALL)
   endif()
 endfunction()
@@ -356,7 +356,7 @@ function(add_phasar_library name)
 
   set_property(GLOBAL APPEND PROPERTY LLVM_EXPORTS ${name})
 
-  if ("${CMAKE_BUILD_TYPE}" STREQUAL "Debug" AND CODE_COVERAGE AND NOT PHASAR_DEBUG_LIBDEPS)
+  if ("${CMAKE_BUILD_TYPE}" STREQUAL "Debug" AND CODE_COVERAGE)
     target_code_coverage(${name} AUTO ALL)
   endif()
 endfunction(add_phasar_library)