Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete private IP ranges #15

Open
adam-p opened this issue Mar 29, 2022 · 0 comments
Open

Incomplete private IP ranges #15

adam-p opened this issue Mar 29, 2022 · 0 comments

Comments

@adam-p
Copy link

adam-p commented Mar 29, 2022

The privateMasks list is incomplete. Here is a good list to use:
https://github.com/letsencrypt/boulder/blob/30a516737c9daa4c88c8c47070c25a5e7033cdcf/bdns/dns.go#L31-L145

(Then you can also remove the ip.IsGlobalUnicast check.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adam-p