Skip to content

Commit da3b614

Browse files
Use Xml::asString() and Filesystem::write()
1 parent 6cda4c6 commit da3b614

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

src/Report/OpenClover.php

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,18 @@
1212
use function assert;
1313
use function basename;
1414
use function count;
15-
use function dirname;
16-
use function file_put_contents;
1715
use function is_string;
1816
use function ksort;
1917
use function max;
2018
use function range;
21-
use function str_contains;
2219
use function str_replace;
2320
use function time;
2421
use DOMDocument;
2522
use DOMElement;
2623
use SebastianBergmann\CodeCoverage\CodeCoverage;
2724
use SebastianBergmann\CodeCoverage\Node\File;
2825
use SebastianBergmann\CodeCoverage\Util\Filesystem;
26+
use SebastianBergmann\CodeCoverage\Util\Xml;
2927
use SebastianBergmann\CodeCoverage\Version;
3028
use SebastianBergmann\CodeCoverage\WriteOperationFailedException;
3129

@@ -240,16 +238,10 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
240238
$xmlMetrics->setAttribute('coveredmethods', (string) $report->numberOfTestedMethods());
241239
$xmlProject->insertBefore($xmlMetrics, $xmlProject->firstChild);
242240

243-
$buffer = $xmlDocument->saveXML();
241+
$buffer = Xml::asString($xmlDocument);
244242

245243
if ($target !== null) {
246-
if (!str_contains($target, '://')) {
247-
Filesystem::createDirectory(dirname($target));
248-
}
249-
250-
if (@file_put_contents($target, $buffer) === false) {
251-
throw new WriteOperationFailedException($target);
252-
}
244+
Filesystem::write($target, $buffer);
253245
}
254246

255247
return $buffer;

0 commit comments

Comments
 (0)