Skip to content

Commit c66fdbd

Browse files
Remove name and crap attributes from <line> element
1 parent 4b9563f commit c66fdbd

File tree

4 files changed

+9
-19
lines changed

4 files changed

+9
-19
lines changed

src/Report/Clover.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,8 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
108108
$lines[$method['startLine']] = [
109109
'ccn' => $method['ccn'],
110110
'count' => $methodCount,
111-
'crap' => $method['crap'],
112111
'type' => 'method',
113112
'visibility' => $method['visibility'],
114-
'name' => $methodName,
115113
];
116114
}
117115

@@ -150,10 +148,6 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
150148
$xmlLine->setAttribute('num', (string) $line);
151149
$xmlLine->setAttribute('type', $data['type']);
152150

153-
if (isset($data['name'])) {
154-
$xmlLine->setAttribute('name', $data['name']);
155-
}
156-
157151
if (isset($data['visibility'])) {
158152
$xmlLine->setAttribute('visibility', $data['visibility']);
159153
}
@@ -162,10 +156,6 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
162156
$xmlLine->setAttribute('complexity', (string) $data['ccn']);
163157
}
164158

165-
if (isset($data['crap'])) {
166-
$xmlLine->setAttribute('crap', (string) $data['crap']);
167-
}
168-
169159
$xmlLine->setAttribute('count', (string) $data['count']);
170160
$xmlFile->appendChild($xmlLine);
171161
}

tests/_files/BankAccount-clover-line.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,16 @@
99
<class name="BankAccount">
1010
<metrics complexity="5" elements="12" coveredelements="8" conditionals="0" coveredconditionals="0" statements="8" coveredstatements="5" methods="4" coveredmethods="3"/>
1111
</class>
12-
<line num="6" type="method" name="getBalance" visibility="public" complexity="1" crap="1" count="2"/>
12+
<line num="6" type="method" visibility="public" complexity="1" count="2"/>
1313
<line num="8" type="stmt" count="2"/>
14-
<line num="11" type="method" name="setBalance" visibility="protected" complexity="2" crap="6" count="0"/>
14+
<line num="11" type="method" visibility="protected" complexity="2" count="0"/>
1515
<line num="13" type="stmt" count="0"/>
1616
<line num="14" type="stmt" count="0"/>
1717
<line num="16" type="stmt" count="0"/>
18-
<line num="20" type="method" name="depositMoney" visibility="public" complexity="1" crap="1" count="2"/>
18+
<line num="20" type="method" visibility="public" complexity="1" count="2"/>
1919
<line num="22" type="stmt" count="2"/>
2020
<line num="24" type="stmt" count="1"/>
21-
<line num="27" type="method" name="withdrawMoney" visibility="public" complexity="1" crap="1" count="2"/>
21+
<line num="27" type="method" visibility="public" complexity="1" count="2"/>
2222
<line num="29" type="stmt" count="2"/>
2323
<line num="31" type="stmt" count="1"/>
2424
</file>

tests/_files/BankAccount-clover-path.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,16 @@
99
<class name="BankAccount">
1010
<metrics complexity="5" elements="19" coveredelements="11" conditionals="7" coveredconditionals="3" statements="8" coveredstatements="5" methods="4" coveredmethods="3"/>
1111
</class>
12-
<line num="6" type="method" name="getBalance" visibility="public" complexity="1" crap="1" count="2"/>
12+
<line num="6" type="method" visibility="public" complexity="1" count="2"/>
1313
<line num="8" type="stmt" count="2"/>
14-
<line num="11" type="method" name="setBalance" visibility="protected" complexity="2" crap="6" count="0"/>
14+
<line num="11" type="method" visibility="protected" complexity="2" count="0"/>
1515
<line num="13" type="stmt" count="0"/>
1616
<line num="14" type="stmt" count="0"/>
1717
<line num="16" type="stmt" count="0"/>
18-
<line num="20" type="method" name="depositMoney" visibility="public" complexity="1" crap="1" count="2"/>
18+
<line num="20" type="method" visibility="public" complexity="1" count="2"/>
1919
<line num="22" type="stmt" count="2"/>
2020
<line num="24" type="stmt" count="1"/>
21-
<line num="27" type="method" name="withdrawMoney" visibility="public" complexity="1" crap="1" count="2"/>
21+
<line num="27" type="method" visibility="public" complexity="1" count="2"/>
2222
<line num="29" type="stmt" count="2"/>
2323
<line num="31" type="stmt" count="1"/>
2424
</file>

tests/_files/class-with-anonymous-function-clover.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<class name="CoveredClassWithAnonymousFunctionInStaticMethod">
1010
<metrics complexity="1" elements="9" coveredelements="9" conditionals="0" coveredconditionals="0" statements="8" coveredstatements="8" methods="1" coveredmethods="1"/>
1111
</class>
12-
<line num="5" type="method" name="runAnonymous" visibility="public" complexity="1" crap="1" count="1"/>
12+
<line num="5" type="method" visibility="public" complexity="1" count="1"/>
1313
<line num="7" type="stmt" count="1"/>
1414
<line num="9" type="stmt" count="1"/>
1515
<line num="10" type="stmt" count="1"/>

0 commit comments

Comments
 (0)