Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to manually set the end date #253

Open
wfleischer opened this issue Feb 27, 2025 · 2 comments
Open

Allow to manually set the end date #253

wfleischer opened this issue Feb 27, 2025 · 2 comments
Labels
good first issue Good for newcomers

Comments

@wfleischer
Copy link
Collaborator

No description provided.

@wfleischer wfleischer added the good first issue Good for newcomers label Feb 27, 2025
@Laihu08
Copy link

Laihu08 commented Mar 4, 2025

Hi @wfleischer,

I’d love to work on this feature! 🎯

Understanding the Feature Request

From the title, it looks like the goal is to allow users to manually set the end date for a reading plan instead of relying on an automatically calculated one.

Implementation Plan:

  1. Identify Affected Components

    • Locate where reading plans currently determine the end date.
    • Identify the UI and database logic that manages this information.
  2. Add Manual End Date Selection

    • Implement a date picker in the UI to allow users to select a custom end date.
    • Ensure that the manual end date overrides any automatically calculated end date when set.
  3. Modify Data Handling

    • Update the Plan data model to support a manually set end date.
  4. Update UI & Save Logic

    • Modify the Plan settings page to include the option to set/edit the end date.
    • Display the manually set end date where relevant.
  5. Test & Validate

    • Ensure that manually setting the end date does not break other plan logic.
    • Validate correct date persistence and retrieval.

Questions for Clarification:

🔹 Should this feature be optional (i.e., users can manually set an end date OR use the auto-calculated one)?
🔹 Should the manually set end date apply retroactively to active plans, or only when creating new ones?

Let me know your thoughts! If you're okay with this approach, I'll start working on it and submit a PR soon. 🚀

Thanks!

@wfleischer
Copy link
Collaborator Author

Hi @Laihu08,

Thank you so much for your enthusiasm and for outlining such a thoughtful approach! I really appreciate your willingness to contribute to this feature.

Your understanding of the feature request is spot on. Yes, the goal is to provide users with an option to manually control the end date in the plans edit dialog, acting as an alternative to the existing "reset end date" option.

Looking at how the "reset end date" functionality is implemented should give you a good starting point for the data handling and logic needed for this feature.

I'm happy to provide any further information or clarification you need. Just let me know! I look forward to seeing your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants