Skip to content

Commit 2da4367

Browse files
authored
Release 2.3.0 - update version and fix fastlane configuration (#169)
* Release 2.3.0 - update version and fix fastlane configuration * Remove codecov references
1 parent d6f83c1 commit 2da4367

8 files changed

Lines changed: 12 additions & 45 deletions

File tree

.codecov.yml

Lines changed: 0 additions & 26 deletions
This file was deleted.

.github/workflows/ci.yml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,7 @@ jobs:
4949
echo "No xcresult bundle found, skipping coverage export"
5050
fi
5151
52-
- name: Upload coverage to Codecov
53-
if: success() && hashFiles('./test_output/coverage.json') != ''
54-
uses: codecov/codecov-action@v4
55-
with:
56-
files: ./test_output/coverage.json
57-
token: ${{ secrets.CODECOV_TOKEN }}
58-
fail_ci_if_error: false
59-
52+
6053
- name: Upload test results
6154
uses: actions/upload-artifact@v4
6255
if: always()

BluePlaquesLondon.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,7 @@
908908
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
909909
CODE_SIGN_IDENTITY = "iPhone Developer";
910910
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
911-
CURRENT_PROJECT_VERSION = 9;
911+
CURRENT_PROJECT_VERSION = 14;
912912
DEVELOPMENT_TEAM = 3TQU8WFYZ9;
913913
FRAMEWORK_SEARCH_PATHS = (
914914
"$(inherited)",
@@ -920,7 +920,7 @@
920920
INFOPLIST_FILE = BluePlaquesLondon/Info.plist;
921921
IPHONEOS_DEPLOYMENT_TARGET = 18.0;
922922
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
923-
MARKETING_VERSION = 2.2;
923+
MARKETING_VERSION = 2.3.0;
924924
PRODUCT_BUNDLE_IDENTIFIER = "com.upwardsnorthwards.$(PRODUCT_NAME:rfc1034identifier)";
925925
PRODUCT_NAME = "$(TARGET_NAME)";
926926
PROVISIONING_PROFILE = "";
@@ -938,7 +938,7 @@
938938
CLANG_ENABLE_CODE_COVERAGE = NO;
939939
CODE_SIGN_IDENTITY = "iPhone Developer";
940940
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
941-
CURRENT_PROJECT_VERSION = 9;
941+
CURRENT_PROJECT_VERSION = 14;
942942
DEVELOPMENT_TEAM = 3TQU8WFYZ9;
943943
FRAMEWORK_SEARCH_PATHS = (
944944
"$(inherited)",
@@ -948,7 +948,7 @@
948948
INFOPLIST_FILE = BluePlaquesLondon/Info.plist;
949949
IPHONEOS_DEPLOYMENT_TARGET = 18.0;
950950
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
951-
MARKETING_VERSION = 2.2;
951+
MARKETING_VERSION = 2.3.0;
952952
OTHER_CFLAGS = (
953953
"$(inherited)",
954954
"-isystem",

BluePlaquesLondon/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<key>CFBundlePackageType</key>
1818
<string>APPL</string>
1919
<key>CFBundleShortVersionString</key>
20-
<string>2.3</string>
20+
<string>2.3.0</string>
2121
<key>CFBundleSignature</key>
2222
<string>????</string>
2323
<key>CFBundleURLTypes</key>
@@ -32,7 +32,7 @@
3232
</dict>
3333
</array>
3434
<key>CFBundleVersion</key>
35-
<string>9</string>
35+
<string>14</string>
3636
<key>ITSAppUsesNonExemptEncryption</key>
3737
<string>NO</string>
3838
<key>LSRequiresIPhoneOS</key>

BluePlaquesLondonTests/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@
1919
<key>CFBundleSignature</key>
2020
<string>????</string>
2121
<key>CFBundleVersion</key>
22-
<string>9</string>
22+
<string>14</string>
2323
</dict>
2424
</plist>

DEVELOPMENT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ GOOGLE_MAPS_API_KEY=your_google_maps_api_key_here
7272
APP_STORE_CONNECT_API_KEY_KEY_ID=your_key_id
7373
APP_STORE_CONNECT_API_KEY_ISSUER_ID=your_issuer_id
7474
APP_STORE_CONNECT_API_KEY=your_p8_file_contents
75-
CODECOV_TOKEN=your_codecov_token
75+
7676
```
7777

7878
**Note**: For `APP_STORE_CONNECT_API_KEY`, copy the entire contents of your `.p8` file including the `-----BEGIN PRIVATE KEY-----` and `-----END PRIVATE KEY-----` lines.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Discover London's rich history through its famous blue plaques! This iOS app hel
55
[📱 Download on the App Store](https://apps.apple.com/app/blue-plaques-london/id427106068)
66

77
[![CI Status](https://github.com/seanoshea/BluePlaquesLondon/workflows/CI/badge.svg)](https://github.com/seanoshea/BluePlaquesLondon/actions/workflows/ci.yml)
8-
[![Code Coverage](http://codecov.io/github/seanoshea/BluePlaquesLondon/coverage.svg?branch=develop)](http://codecov.io/github/seanoshea/BluePlaquesLondon?branch=develop)
8+
99
[![PRs Welcome](https://img.shields.io/badge/prs-welcome-brightgreen.svg?style=flat-square)](http://makeapullrequest.com)
1010
[![License](http://img.shields.io/badge/license-BSD-green.svg?style=flat)](https://github.com/seanoshea/BluePlaquesLondon/blob/master/LICENSE)
1111
[![Twitter: @seanoshea](https://img.shields.io/badge/contact-@seanoshea-blue.svg?style=flat)](https://twitter.com/seanoshea)

fastlane/Fastfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ end
7979

8080
lane :release do
8181
setup
82-
increment_version_number(bump_type: "patch")
8382
increment_build_number(xcodeproj: "BluePlaquesLondon.xcodeproj")
8483
gym(
8584
scheme: "BluePlaquesLondon",
@@ -93,6 +92,7 @@ lane :release do
9392
key_filepath: "fastlane/api_keys/AuthKey_#{ENV['APP_STORE_CONNECT_API_KEY_KEY_ID']}.p8"
9493
),
9594
force: true,
96-
submit_for_review: false
95+
submit_for_review: false,
96+
precheck_include_in_app_purchases: false
9797
)
9898
end

0 commit comments

Comments
 (0)