Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Asterisk 14.0.1 #28

Closed
amessina opened this issue Sep 27, 2016 · 7 comments
Closed

Update for Asterisk 14.0.1 #28

amessina opened this issue Sep 27, 2016 · 7 comments

Comments

@amessina
Copy link

Asterisk 14.0.1 includes it's own method of downloading a precompiled codec_opus.so binary which phones home. Maybe rename the codec so it can be enabled/disabled separately in menuslect.

@seanbright
Copy link
Owner

If the concern is that it phones home, just add a fake entry in /etc/hosts for stats.asterisk.org and it won't be able to.

@amessina
Copy link
Author

@seanbright, it's not that it's my primary concern. It didn't make sense to me that with all of the opus-related tools and your work to this point freely available to build against shared libraries, that Asterisk/Digium would need to create their own version with its own license.

Your suggestion is a good one however. Thank you.

@seanbright
Copy link
Owner

Yeah, it doesn't make sense to me either, but what can you do?

@amessina
Copy link
Author

I was thinking that there needs to be a way to include this version of codec opus in menuselect. Right now if one disables 'codec_opus', you get a conflict as they're named the same.

Is your thought that this repository will eventually "go away" as opus support is beginning to move into Asterisk?

@seanbright
Copy link
Owner

Yes.

@amessina
Copy link
Author

I completely understand. Thanks for pushing it to this point!

@traud
Copy link
Collaborator

traud commented Oct 17, 2016

Thank you for reporting! One cannot test all versions and configurations. For example, I am still with Asterisk 13.11.2. Therefore it is always good to report such things. Because the upcoming Asterisk 13.12 is going to face the same issue, I am reopening this issue report.

I am going to submit a Pull Request shortly – linking to this issue report. The change should be compatible with Asterisk 14.0.2 and 13.12, still retaining compatibility back to 13.3. If that did not fix your issue or a new regression was introduced, please, reopen this issue report.

Thanks again for reporting and avoiding a headache for your fellows.

@traud traud reopened this Oct 17, 2016
traud added a commit to traud/asterisk-opus that referenced this issue Oct 17, 2016
renamed the file codec_opus.c to codec_opus_open_source.c
closes seanbright#28
traud added a commit that referenced this issue Oct 17, 2016
renamed the file codec_opus.c to codec_opus_open_source.c
closes #28
@traud traud closed this as completed Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants