Skip to content

Commit 0a08157

Browse files
authored
Remove support for Python 3.8 (#804)
1 parent 8bca5ef commit 0a08157

File tree

8 files changed

+12
-13
lines changed

8 files changed

+12
-13
lines changed

.github/workflows/install.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
strategy:
1717
fail-fast: true
1818
matrix:
19-
python_version: ["3.8", "3.13"]
19+
python_version: ["3.9", "3.13"]
2020
runs-on: ubuntu-latest
2121
steps:
2222
- name: Set up python ${{ matrix.python_version }}

.github/workflows/integration.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ jobs:
1414
runs-on: ${{ matrix.os }}
1515
strategy:
1616
matrix:
17-
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
17+
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
1818
os: [ubuntu-latest, windows-latest]
1919
include:
2020
- os: macos-latest
21-
python-version: '3.8'
21+
python-version: '3.9'
2222
- os: macos-latest
2323
python-version: '3.13'
2424
steps:

.github/workflows/minimum.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ jobs:
1414
runs-on: ${{ matrix.os }}
1515
strategy:
1616
matrix:
17-
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
17+
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
1818
os: [ubuntu-latest, windows-latest]
1919
include:
2020
- os: macos-latest
21-
python-version: '3.8'
21+
python-version: '3.9'
2222
- os: macos-latest
2323
python-version: '3.13'
2424
steps:

.github/workflows/readme.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
runs-on: ${{ matrix.os }}
1515
strategy:
1616
matrix:
17-
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
17+
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
1818
os: [ubuntu-latest, macos-latest] # skip windows bc rundoc fails
1919
steps:
2020
- uses: actions/checkout@v4

.github/workflows/unit.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ jobs:
1414
runs-on: ${{ matrix.os }}
1515
strategy:
1616
matrix:
17-
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
17+
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
1818
os: [ubuntu-latest, windows-latest]
1919
include:
2020
- os: macos-latest
21-
python-version: '3.8'
21+
python-version: '3.9'
2222
- os: macos-latest
2323
python-version: '3.13'
2424
steps:

INSTALL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Requirements
44

5-
**SDMetrics** has been developed and tested on [Python 3.8, 3.9, 3.10, 3.11, 3.12 and 3.13](https://www.python.org/downloads/)
5+
**SDMetrics** has been developed and tested on [Python 3.9, 3.10, 3.11, 3.12 and 3.13](https://www.python.org/downloads/)
66

77
Also, although it is not strictly required, the usage of a [virtualenv](
88
https://virtualenv.pypa.io/en/latest/) is highly recommended in order to avoid

pyproject.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ classifiers = [
88
'License :: OSI Approved :: MIT License',
99
'Natural Language :: English',
1010
'Programming Language :: Python :: 3',
11-
'Programming Language :: Python :: 3.8',
1211
'Programming Language :: Python :: 3.9',
1312
'Programming Language :: Python :: 3.10',
1413
'Programming Language :: Python :: 3.11',
@@ -18,7 +17,7 @@ classifiers = [
1817
keywords = ['sdmetrics', 'sdmetrics', 'SDMetrics']
1918
dynamic = ['version']
2019
license = { text = 'MIT license' }
21-
requires-python = ">=3.8,<3.14"
20+
requires-python = ">=3.9,<3.14"
2221
readme = 'README.md'
2322
dependencies = [
2423
"numpy>=1.22.2;python_version<'3.10'",

sdmetrics/single_table/new_row_synthesis.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,8 @@ def compute_breakdown(
148148
except TypeError:
149149
if len(real_data) > 10000:
150150
warnings.warn(
151-
'Unable to optimize query. For better formance, set the '
152-
'`synthetic_sample_size` parameter or upgrade to Python 3.8'
151+
'Unable to optimize query. For better performance, set the '
152+
'`synthetic_sample_size` parameter.'
153153
)
154154

155155
matches = real_data.query(' and '.join(row_filter), engine='python')

0 commit comments

Comments
 (0)