Update Finishes & Print attributes (#18)

* deprecate ampersand

* add `poster` to PrintAttribute.ts (#13)

* add `embossed` to Finishes.ts (#12)

* add `scroll` to Finishes.ts (#11)

* mv scroll to print attributes

* document all the print attributes

---------

Co-authored-by: Andrew McKnight <[email protected]>

Author: scarletcs

src/objects/Card/values/Finishes.ts

@@ -19,18 +19,12 @@ export enum ScryfallExtendedFinish {
    * The confetti foil finish. This looks glimmery like confetti laying on top of the card.
    */
   ConfettiFoil = "confettifoil",
-  /**
-   * The Dungeons & Dragons glossy finish that superimposed an ampersand over the card.
-   */
-  Ampersand = "ampersand",
   /**
    * Galaxy foil.
-   * TODO
    */
   GalaxyFoil = "galaxyfoil",
   /**
    * Halo foil.
-   * TODO
    */
   HaloFoil = "halofoil",
   /**
@@ -62,6 +56,18 @@ export enum ScryfallExtendedFinish {
    * @trivia The name was a reference to "step and repeat", a style of pattern used in printing banners.
    */
   StepAndCompleat = "stepandcompleat",
+  /**
+   * A glossy finish with an emblem embossed on it.
+   *
+   * Examples include the D&D Ampersand logo or REX Jurassic Park logo.
+   */
+  Embossed = "embossed",
+  /**
+   * The Dungeons & Dragons glossy finish that superimposed an ampersand over the card.
+   *
+   * @deprecated This is replaced by {@link Embossed} instead.
+   */
+  Ampersand = "ampersand",
 }
 
 export type ScryfallExtendedFinishLike = ScryfallExtendedFinish | `${ScryfallExtendedFinish}`;

src/objects/Card/values/PrintAttribute.ts

@@ -1,53 +1,219 @@
 import { ScryfallExtendedFinish } from "./Finishes";
 
 type ScryfallPrintAttribute =
+  /**
+   * Cards exclusive to the Alchemy format in Arena.
+   */
   | "alchemy"
+  /**
+   * Arena League prize cards.
+   *
+   * No relation to the video game.
+   *
+   * @trivia Arena League was a competitive event that ran from 1996 to 2007.
+   */
   | "arenaleague"
+  /**
+   * Project Booster Fun cards.
+   */
   | "boosterfun"
+  /**
+   * Box topper promotional cards found in some sets' booster boxes.
+   */
   | "boxtopper"
+  /**
+   * Prints exclusive to brawl decks.
+   */
   | "brawldeck"
+  /**
+   * Bring-a-friend store event promos.
+   */
   | "bringafriend"
+  /**
+   * Bundle promos.
+   */
   | "bundle"
+  /**
+   * Buyabox promos.
+   */
   | "buyabox"
+  /**
+   * Commander party promos.
+   */
   | "commanderparty"
+  /**
+   * Concept praetors.
+   */
   | "concept"
+  /**
+   * Convention promos.
+   */
   | "convention"
+  /**
+   * Cards datestamped in the corner of the art frame.
+   */
   | "datestamped"
+  /**
+   * Dracula series cards.
+   */
   | "draculaseries"
+  /**
+   * Draft weekend event promo cards.
+   */
   | "draftweekend"
+  /**
+   * Duels of the Planeswalkers promos.
+   */
   | "duels"
+  /**
+   * Event promos.
+   */
   | "event"
+  /**
+   * FNM promos.
+   */
   | "fnm"
+  /**
+   * Game day promos.
+   */
   | "gameday"
+  /**
+   * Gift box promos.
+   */
   | "giftbox"
+  /**
+   * Godzilla series cards.
+   */
   | "godzillaseries"
+  /**
+   * Instore event promos.
+   */
   | "instore"
+  /**
+   * Prints exclusive to intro packs/decks.
+   */
   | "intropack"
+  /**
+   * Cards in the Japanese planeswalker series.
+   */
   | "jpwalker"
+  /**
+   * Judge program gift cards.
+   */
   | "judgegift"
+  /**
+   * Miscellaneous promos marked as League promos, e.g. APAC league.
+   */
   | "league"
+  /**
+   * Media inserts, e.g. prints given out packaged with magazines or books.
+   */
   | "mediainsert"
+  /**
+   * Cards in the moonlit land series.
+   */
   | "moonlitland"
+  /**
+   * Openhouse promos.
+   */
   | "openhouse"
+  /**
+   * Prints exclusive to planeswalker decks.
+   */
   | "planeswalkerdeck"
+  /**
+   * Cards printed on plastic stock.
+   */
   | "plastic"
+  /**
+   * Player rewards promos.
+   */
   | "playerrewards"
+  /**
+   * Play promos.
+   */
   | "playpromo"
+  /**
+   * Cards with a “poster” appearance.
+   */
+  | "poster"
+  /**
+   * Premier e-Shop promos.
+   */
   | "premiereshop"
+  /**
+   * Prerelease event datestamped cards.
+   */
   | "prerelease"
+  /**
+   * Cards found in promo packs.
+   *
+   * @see "stamped"
+   */
   | "promopack"
+  /**
+   * Cards that are rebalanced versions for the Alchemy format in Arena.
+   */
   | "rebalanced"
+  /**
+   * Release event promos.
+   */
   | "release"
+  /**
+   * Simplified chinese alt-art cards.
+   *
+   * Due to Chinese censorship rules, some cards receive alternate art in Chinese releases.
+   */
   | "schinesealtart"
+  /**
+   * A Lord of the Rings appearance that made the card name, type line and oracle text area appear as scrolls.
+   */
+  | "scroll"
+  /**
+   * Serialized cards. (001/500, etc.)
+   */
   | "serialized"
+  /**
+   * Set Extension cards.
+   *
+   * E.g.: Rafiq of the Many had a gilded showcase released in SNC boosters.
+   * It was given the collector info ALA 250, extending the original Alara set code.
+   * Scryfall records this in the ALA sert because that's the set code, but we mark it as an “extension” of that set.
+   */
   | "setextension"
+  /**
+   * (TODO)
+   */
   | "setpromo"
+  /**
+   * Cards stamped with a planeswalker symbol in the corner of the art frame released in store boosters.
+   *
+   * Not to be confused with The List cards, which have a small planeswalker symbol in the bottom left corner of the card.
+   */
   | "stamped"
+  /**
+   * Prints found exclusively in a starter deck.
+   */
   | "starterdeck"
+  /**
+   * Store championship participation and prize cards.
+   */
   | "storechampionship"
+  /**
+   * Prints found exclusively in theme boosters.
+   */
   | "themepack"
+  /**
+   * Cards printed on extra-thick cardstock.
+   */
   | "thick"
+  /**
+   * Tournament promo cards.
+   */
   | "tourney"
+  /**
+   * Wizards play network promo cards.
+   */
   | "wizardsplaynetwork";
 
 export type ScryfallPromoType = ScryfallPrintAttribute | `${ScryfallExtendedFinish}`;