Skip to content

feat: support verify block signature signed by RN #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

feat: support verify block signature signed by RN #1236

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5b12d17
feat: support extract block signature from extra_data field
yiweichi Aug 25, 2025
cc14c26
add logs
yiweichi Aug 25, 2025
75a98d4
remove ErrInvalidRecoveryID check
yiweichi Aug 25, 2025
781e5ac
fix: accepts signature from reth node's alloy signer
yiweichi Aug 26, 2025
a3dc7c2
add more logs
yiweichi Aug 26, 2025
8f9c52b
add more logs
yiweichi Aug 26, 2025
4989da5
revert all logs
yiweichi Aug 26, 2025
45ab53a
update notation
yiweichi Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions consensus/system_contract/consensus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,13 @@ func SealHash(header *types.Header) (hash common.Hash) {
// ecrecover extracts the Ethereum account address from a signed header.
func ecrecover(header *types.Header) (common.Address, error) {
signature := header.BlockSignature[0:]
// Normalize recovery ID for compatibility with Scroll's rollup node.
// Scroll's rollup node uses alloy signer which produces signatures with recovery ID (V) of 27/28,
// but go-ethereum's standard crypto.Ecrecover expects V to be 0/1.
// Convert 27/28 format to 0/1 format by subtracting 27.
if signature[64] >= 27 && signature[64] <= 28 {
signature[64] -= 27
}

// Recover the public key and the Ethereum address
pubkey, err := crypto.Ecrecover(SealHash(header).Bytes(), signature)
Expand Down
Loading