Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WHIR wrapper #642

Open
icemelon opened this issue Nov 27, 2024 · 3 comments
Open

WHIR wrapper #642

icemelon opened this issue Nov 27, 2024 · 3 comments
Assignees
@chaosma @yczhangsjtu

Comments

@icemelon
Copy link
Member

icemelon commented Nov 27, 2024 •
edited by kunxian-xia
Loading

The goal of this task is to make a wrapper of https://github.com/scroll-tech/whir to be compatible with the traits that we have for mpcs in ceno right now.
@icemelon icemelon moved this to Todo in Ceno - Recursion Nov 27, 2024
@kunxian-xia
Copy link
Collaborator

@yczhangsjtu @chaosma Could you start to work on this?

@kunxian-xia kunxian-xia moved this from Todo to In Progress in Ceno - Recursion Dec 3, 2024
@lispc
Copy link
Collaborator

lispc commented Dec 10, 2024 •
edited by yczhangsjtu
Loading

Sub Tasks

  • Bridging ff and ark-ff (untested)
  • Implement PCS trait for WHIR
    • Serialization
    • Transcript
    • Commitment handling
  • testing with existing test cases (originally designed for BaseFold), and report performance gain. (proving time, proof size, verification time)

current plan:
Dec 23: likely testing done, in review phase.

@kunxian-xia
Copy link
Collaborator

@yczhangsjtu please update the links to pull requests.

This was referenced Dec 12, 2024
Closed
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2025
@yczhangsjtu @hero78119
WHIR wrapper (#742)
59e74dc 
Add the implementation of WHIR from  #642

---------

Co-authored-by: Ming <[email protected]>
yczhangsjtu added a commit to scroll-tech/whir that referenced this issue Feb 26, 2025
@yczhangsjtu
Support traits to match requirement in Ceno. (#6)
2b25624 
- [x] Finished coding for bridging ff and ark-ff (on Ceno side, untested
yet)
- [x] More to bridge between WHIR and Ceno
[#642](scroll-tech/ceno#642)
- Transcript mismatch (one v.s. two transcripts for read/write
respectively)
    - Serialization (serde v.s. ark-serialize)
        - Config (Param in WHIR, hash params, no need to serialize)
        - Setup Param (no corresponding thing in WHIR)
        - Commitment (digest)
        - CommitmentWithData (not serialized in WHIR)
        - Proof (ark-serialized in WHIR)
- Commitment handling (WHIR API doesn't have a Commitment struct, prover
directly writes Merkle root to transcript for the verifier to read
later)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chaosma chaosma

@yczhangsjtu yczhangsjtu

Labels
None yet
Projects
Ceno - Recursion
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kunxian-xia @icemelon @lispc @chaosma @yczhangsjtu