New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zkvm opcode tests (wenqing, week 4) #40

Open

Tracked by

zhenfeizhang opened this issue Jan 30, 2024 · 2 comments

Open

Tracked by

zkvm opcode tests (wenqing, week 4) #40

zhenfeizhang opened this issue Jan 30, 2024 · 2 comments

Assignees

Contributor

zhenfeizhang commented Jan 30, 2024

No description provided.

zhenfeizhang mentioned this issue

[macro issue] implemetation roadmap #8

Open

30 tasks

Contributor Author

zhenfeizhang commented Jan 30, 2024

https://github.com/scroll-tech/singer/tree/singer-opcode-tests-Wenqing

create a draft PR for this issue
we can use randomized challenge for tests (we have not integrated transcripts)

Contributor

huwenqing0606 commented Jan 31, 2024

a drafted PR created. maybe worth look into carefully these two lines (1) https://github.com/scroll-tech/singer/blob/14a20b64ea3592ee62819191678eac79192fa772/singer/src/instructions/utils/uint.rs#L168 left shift overflow? (2) https://github.com/scroll-tech/singer/blob/14a20b64ea3592ee62819191678eac79192fa772/gkr/src/circuit/circuit_witness.rs#L77 must ensure old_layer_id>layer_id? but for inputs the paste_from uses wire_in id's as key

huwenqing0606 self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment