feat: add secp256k1 ecrecover precompile (#1078)

patch crate:
https://github.com/scroll-tech/elliptic-curves/tree/ceno/k256-13.4

test_secp256k1_ecrecover, runs 5 ecrecover:
- with precompile: 3845214 steps
- without: 65928672 steps

Author: lightsing

Cargo.lock

@@ -4,6 +4,7 @@ members = [
   "ceno_emul",
   "ceno_host",
   "ceno_rt",
+  "ceno_syscall",
   "ceno_zkvm",
   "derive",
   "examples-builder",
@@ -40,7 +41,7 @@ cfg-if = "1.0"
 clap = { version = "4.5", features = ["derive"] }
 criterion = { version = "0.5", features = ["html_reports"] }
 either = { version = "1.15.*", features = ["serde"] }
-generic-array = { version = "*", features = ["alloc", "serde"] }
+generic-array = { version = "1.2", features = ["alloc", "serde"] }
 itertools = "0.13"
 ndarray = "*"
 num-derive = "0.4"

Cargo.toml

@@ -12,6 +12,7 @@ version.workspace = true
 [dependencies]
 anyhow.workspace = true
 ceno_rt = { path = "../ceno_rt" }
+ceno_syscall = { path = "../ceno_syscall" }
 elf = "0.7"
 ff_ext.workspace = true
 itertools.workspace = true

ceno_emul/Cargo.toml

@@ -9,7 +9,7 @@ pub mod sha256;
 // Using the same function codes as sp1:
 // https://github.com/succinctlabs/sp1/blob/013c24ea2fa15a0e7ed94f7d11a7ada4baa39ab9/crates/core/executor/src/syscalls/code.rs
 
-pub use ceno_rt::syscalls::{
+pub use ceno_syscall::{
     BLS12381_ADD, BLS12381_DECOMPRESS, BLS12381_DOUBLE, BN254_ADD, BN254_DOUBLE, BN254_FP_ADD,
     BN254_FP_MUL, BN254_FP2_ADD, BN254_FP2_MUL, KECCAK_PERMUTE, SECP256K1_ADD,
     SECP256K1_DECOMPRESS, SECP256K1_DOUBLE, SECP256R1_ADD, SECP256R1_DECOMPRESS, SECP256R1_DOUBLE,

ceno_emul/src/syscalls.rs

@@ -13,7 +13,7 @@ impl SyscallSpec for Bn254AddSpec {
 
     const REG_OPS_COUNT: usize = 2;
     const MEM_OPS_COUNT: usize = 2 * BN254_POINT_WORDS;
-    const CODE: u32 = ceno_rt::syscalls::BN254_ADD;
+    const CODE: u32 = ceno_syscall::BN254_ADD;
 }
 
 pub struct Bn254DoubleSpec;
@@ -22,7 +22,7 @@ impl SyscallSpec for Bn254DoubleSpec {
 
     const REG_OPS_COUNT: usize = 2;
     const MEM_OPS_COUNT: usize = BN254_POINT_WORDS;
-    const CODE: u32 = ceno_rt::syscalls::BN254_DOUBLE;
+    const CODE: u32 = ceno_syscall::BN254_DOUBLE;
 }
 
 pub fn bn254_add(vm: &VMState) -> SyscallEffects {

ceno_emul/src/syscalls/bn254/bn254_curve.rs

@@ -17,7 +17,7 @@ impl SyscallSpec for Bn254FpAddSpec {
 
     const REG_OPS_COUNT: usize = 2;
     const MEM_OPS_COUNT: usize = 2 * BN254_FP_WORDS;
-    const CODE: u32 = ceno_rt::syscalls::BN254_FP_ADD;
+    const CODE: u32 = ceno_syscall::BN254_FP_ADD;
 }
 
 pub struct Bn254Fp2AddSpec;
@@ -26,7 +26,7 @@ impl SyscallSpec for Bn254Fp2AddSpec {
 
     const REG_OPS_COUNT: usize = 2;
     const MEM_OPS_COUNT: usize = 2 * BN254_FP2_WORDS;
-    const CODE: u32 = ceno_rt::syscalls::BN254_FP2_ADD;
+    const CODE: u32 = ceno_syscall::BN254_FP2_ADD;
 }
 
 pub struct Bn254FpMulSpec;
@@ -35,7 +35,7 @@ impl SyscallSpec for Bn254FpMulSpec {
 
     const REG_OPS_COUNT: usize = 2;
     const MEM_OPS_COUNT: usize = 2 * BN254_FP_WORDS;
-    const CODE: u32 = ceno_rt::syscalls::BN254_FP_MUL;
+    const CODE: u32 = ceno_syscall::BN254_FP_MUL;
 }
 
 pub struct Bn254Fp2MulSpec;
@@ -44,7 +44,7 @@ impl SyscallSpec for Bn254Fp2MulSpec {
 
     const REG_OPS_COUNT: usize = 2;
     const MEM_OPS_COUNT: usize = 2 * BN254_FP2_WORDS;
-    const CODE: u32 = ceno_rt::syscalls::BN254_FP2_MUL;
+    const CODE: u32 = ceno_syscall::BN254_FP2_MUL;
 }
 
 fn bn254_fptower_binary_op<

ceno_emul/src/syscalls/bn254/bn254_fptower.rs

@@ -15,7 +15,7 @@ impl SyscallSpec for KeccakSpec {
 
     const REG_OPS_COUNT: usize = 1;
     const MEM_OPS_COUNT: usize = KECCAK_WORDS;
-    const CODE: u32 = ceno_rt::syscalls::KECCAK_PERMUTE;
+    const CODE: u32 = ceno_syscall::KECCAK_PERMUTE;
     const HAS_LOOKUPS: bool = true;
 }
 

ceno_emul/src/syscalls/keccak_permute.rs

@@ -14,23 +14,23 @@ impl SyscallSpec for Secp256k1AddSpec {
 
     const REG_OPS_COUNT: usize = 2;
     const MEM_OPS_COUNT: usize = 2 * SECP256K1_ARG_WORDS;
-    const CODE: u32 = ceno_rt::syscalls::SECP256K1_ADD;
+    const CODE: u32 = ceno_syscall::SECP256K1_ADD;
 }
 
 impl SyscallSpec for Secp256k1DoubleSpec {
     const NAME: &'static str = "SECP256K1_DOUBLE";
 
     const REG_OPS_COUNT: usize = 2;
     const MEM_OPS_COUNT: usize = SECP256K1_ARG_WORDS;
-    const CODE: u32 = ceno_rt::syscalls::SECP256K1_DOUBLE;
+    const CODE: u32 = ceno_syscall::SECP256K1_DOUBLE;
 }
 
 impl SyscallSpec for Secp256k1DecompressSpec {
     const NAME: &'static str = "SECP256K1_DECOMPRESS";
 
     const REG_OPS_COUNT: usize = 2;
     const MEM_OPS_COUNT: usize = 2 * COORDINATE_WORDS;
-    const CODE: u32 = ceno_rt::syscalls::SECP256K1_DECOMPRESS;
+    const CODE: u32 = ceno_syscall::SECP256K1_DECOMPRESS;
 }
 
 // A secp256k1 point in uncompressed form takes 64 bytes

ceno_emul/src/syscalls/secp256k1.rs

@@ -11,7 +11,7 @@ impl SyscallSpec for Sha256ExtendSpec {
 
     const REG_OPS_COUNT: usize = 2;
     const MEM_OPS_COUNT: usize = SHA_EXTEND_WORDS;
-    const CODE: u32 = ceno_rt::syscalls::SHA_EXTEND;
+    const CODE: u32 = ceno_syscall::SHA_EXTEND;
 }
 
 /// Wrapper type for the sha_extend argument that implements conversions

ceno_emul/src/syscalls/sha256.rs

@@ -438,6 +438,18 @@ fn test_secp256k1_decompress() -> Result<()> {
     Ok(())
 }
 
+#[test]
+fn test_secp256k1_ecrecover() -> Result<()> {
+    let _ = ceno_host::run(
+        CENO_PLATFORM,
+        ceno_examples::secp256k1_ecrecover,
+        &CenoStdin::default(),
+        None,
+    );
+
+    Ok(())
+}
+
 #[test]
 fn test_sha256_extend() -> Result<()> {
     let program_elf = ceno_examples::sha_extend_syscall;