circuit builder and constrain system share between ceno_zkvm + gkr_iop (#978)

PR build on top of #973 #976

This PR refactor `ConstrainSystem`, `CircuitBuilder` to `gkr-iop`, thus
gkr-iop can leverage few existing utilization implemented in
`ConstrainSystem`, e.g. register_read/write, assert_lt etc.

`CircuitBuilder` some util dedicate to zkvm logic are stayed in original
crate


### benchmark

For fibonacci remain the same (4194304 improvement just due to noise I
guess)
| Benchmark | Median Time (s) | Median Change (%) |

|----------------------------------|------------------|----------------------------------------------|
| fibonacci_max_steps_1048576 | 2.0913 | +0.6455% (No change in
performance detected) |
| fibonacci_max_steps_2097152 | 3.5427 | -0.3998% (No change in
performance detected) |
| fibonacci_max_steps_4194304 | 6.4078 | -10.032% (Performance has
improved) |

For lookup keccak
| Benchmark | Median Time (s) | Median Change (%) |

|----------------------------------|------------------|----------------------------------------------|
| keccak_lookup_f_4096 | 0.88398 | -1.5324% (No change in performance
detected) |
| keccak_lookup_f_8192 | 1.7557 | -1.2695% (No change in performance
detected) |

Author: hero78119

ceno_zkvm/src/chip_handler.rs

@@ -1,22 +1,23 @@
 use ff_ext::ExtensionField;
+use gkr_iop::{error::CircuitBuilderError, gadgets::AssertLtConfig};
 
-use crate::{
-    error::ZKVMError, gadgets::AssertLtConfig, instructions::riscv::constants::UINT_LIMBS,
-};
+use crate::instructions::riscv::constants::UINT_LIMBS;
 use multilinear_extensions::{Expression, ToExpr};
 
 pub mod general;
 pub mod global_state;
 pub mod memory;
 pub mod register;
 
-#[cfg(test)]
-pub mod test;
-
 pub trait GlobalStateRegisterMachineChipOperations<E: ExtensionField> {
-    fn state_in(&mut self, pc: Expression<E>, ts: Expression<E>) -> Result<(), ZKVMError>;
+    fn state_in(&mut self, pc: Expression<E>, ts: Expression<E>)
+    -> Result<(), CircuitBuilderError>;
 
-    fn state_out(&mut self, pc: Expression<E>, ts: Expression<E>) -> Result<(), ZKVMError>;
+    fn state_out(
+        &mut self,
+        pc: Expression<E>,
+        ts: Expression<E>,
+    ) -> Result<(), CircuitBuilderError>;
 }
 
 /// The common representation of a register value.
@@ -31,7 +32,7 @@ pub trait RegisterChipOperations<E: ExtensionField, NR: Into<String>, N: FnOnce(
         prev_ts: Expression<E>,
         ts: Expression<E>,
         value: RegisterExpr<E>,
-    ) -> Result<(Expression<E>, AssertLtConfig), ZKVMError>;
+    ) -> Result<(Expression<E>, AssertLtConfig), CircuitBuilderError>;
 
     #[allow(clippy::too_many_arguments)]
     fn register_write(
@@ -42,7 +43,7 @@ pub trait RegisterChipOperations<E: ExtensionField, NR: Into<String>, N: FnOnce(
         ts: Expression<E>,
         prev_values: RegisterExpr<E>,
         value: RegisterExpr<E>,
-    ) -> Result<(Expression<E>, AssertLtConfig), ZKVMError>;
+    ) -> Result<(Expression<E>, AssertLtConfig), CircuitBuilderError>;
 }
 
 /// The common representation of a memory address.
@@ -59,7 +60,7 @@ pub trait MemoryChipOperations<E: ExtensionField, NR: Into<String>, N: FnOnce()
         prev_ts: Expression<E>,
         ts: Expression<E>,
         value: MemoryExpr<E>,
-    ) -> Result<(Expression<E>, AssertLtConfig), ZKVMError>;
+    ) -> Result<(Expression<E>, AssertLtConfig), CircuitBuilderError>;
 
     #[allow(clippy::too_many_arguments)]
     fn memory_write(
@@ -70,5 +71,5 @@ pub trait MemoryChipOperations<E: ExtensionField, NR: Into<String>, N: FnOnce()
         ts: Expression<E>,
         prev_values: MemoryExpr<E>,
         value: MemoryExpr<E>,
-    ) -> Result<(Expression<E>, AssertLtConfig), ZKVMError>;
+    ) -> Result<(Expression<E>, AssertLtConfig), CircuitBuilderError>;
 }