You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the ShaderManager is geared towards compiling shaders for drawing sprites. However, the PenSkin uses an entirely non-sprite-related shader to draw lines, and PR #489 adds another non-sprite shader in order to be able to draw backgrounds that are properly masked by the stencil buffer.
Currently, these are handled as "draw modes", but this seems hacky. Code for drawing everything is all in sprite.vert and sprite.frag. Perhaps "draw mode" should be split into two parts: "primitive mode" (are we drawing a sprite, line, background, etc) and "draw options" (how are we drawing it).
The text was updated successfully, but these errors were encountered:
Currently, the
ShaderManager
is geared towards compiling shaders for drawing sprites. However, thePenSkin
uses an entirely non-sprite-related shader to draw lines, and PR #489 adds another non-sprite shader in order to be able to draw backgrounds that are properly masked by the stencil buffer.Currently, these are handled as "draw modes", but this seems hacky. Code for drawing everything is all in
sprite.vert
andsprite.frag
. Perhaps "draw mode" should be split into two parts: "primitive mode" (are we drawing a sprite, line, background, etc) and "draw options" (how are we drawing it).The text was updated successfully, but these errors were encountered: