Invalid typeof comparison value in core/xml.js

[alexcui03]

scratch-blocks/core/xml.js

Line 645 in caa389d

if (typeof(type) === undefined || type === null) {

The result of typeof should be a string, which means it won't equals to undefined. (Even typeof undefined is 'undefined')

ESLint will report

error  Invalid typeof comparison value                                            valid-typeof

MDN shows that if the attribute doesn't exist, getAttribute will return null.

Should it be modified to if (typeof type === 'undefined' || type === null) or just if (type === null)?

[eYuM-coder]

@alexcui03, this statement should be if (typeof type == 'undefined' || type == null) for clarification.