Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imbalanced-learn 1.X #645

Open
glemaitre opened this issue Nov 17, 2019 · 1 comment
Open

Imbalanced-learn 1.X #645

glemaitre opened this issue Nov 17, 2019 · 1 comment
Labels
Type: Enhancement Indicates new feature requests
Milestone

Comments

@glemaitre
Copy link
Member

While imbalanced-learn 0.X really focuses on samplers, over time we start to add additional methods like ensemble classifiers. We could think about releasing imbalanced-learn 1.X which could reorganize the methods. We could think about adding cost-sensitive learning method, for instance. One way could be:

  • datasets
  • metrics
  • predictors
  • samplers
  • tests
  • utils

In this case, we would probably import thing with an additional layer:

from imblearn.predictors.ensemble import BalancedRandomForest
from imblearn.samplers.under_sampling import RandomUnderSampler

@chkoar Could you add any thought in this thread.

@glemaitre glemaitre added the Type: Enhancement Indicates new feature requests label Nov 17, 2019
@glemaitre glemaitre added this to the 1.0 milestone Nov 17, 2019
@chkoar
Copy link
Member

chkoar commented Nov 17, 2019

I agree with that hierarchy. Since, the literature distinguish the methods mostly in data level approaches and algorithm level approaches samplers and predictors make totally sense. There are also methods that tackle the problem modifying the feature space. We could add those in the preprocessing module when we have such an implementation.

I believe that we should always import from the second level like this

from imblearn.predictors import BalancedRandomForest
from imblearn.samplers import RandomUnderSampler

An option could be to get rid different base classes and rely to estimators tags. That might give as freedom to make changes more efficiently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

2 participants