Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure that setting upper limit works for toms748 scan #2564

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: ensure that setting upper limit works for toms748 scan #2564

wants to merge 3 commits into from

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Dec 11, 2024

Pull Request Description

Please first read CONTRIBUTING.md.

Please describe the purpose of this pull request in some detail and what bug it fixes. Reference and link to any relevant issues or pull requests (such as the issue in which this bug was first discussed).

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
- resolves #2563
- pass level kwarg from the upper_limits.upper_limit through to toms748 scan
- add test to ensure that a different level being set is actually providing different limits

@kratsg kratsg self-assigned this Dec 11, 2024
@kratsg kratsg added the fix A bug fix label Dec 11, 2024
@matthewfeickert
Copy link
Member

Thanks @kratsg! I'll fixup the CI and review this this week (promise!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewfeickert matthewfeickert Awaiting requested review from matthewfeickert

At least 2 approving reviews are required to merge this pull request.

Assignees

@kratsg kratsg

Labels
fix A bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pyhf.infer.intervals.upper_limits.upper_limit ignores the set confidence level when scan=None
2 participants
@kratsg @matthewfeickert