fix: Cast non-hashable types to floats in toms748_scan #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding tensorflow tests are very slow
matthewfeickert
added
tests
matthewfeickert
commented
Apr 18, 2024
| @@ -72,18 +73,20 @@ def test_toms748_scan_bounds_extension(hypotest_args): | |||
| data, model, 3, 5, rtol=1e-8 | |||
| ) | |||
|
|
|||
| assert observed_limit == pytest.approx(observed_limit_default) | |||
| # FIXME: Remove float cast after TensorFlow support removed | |||
There was a problem hiding this comment.
@kratsg Running the TensorFlow tests is very slow and adds minutes to this run. As we're going to be dropping TensorFlow in the future, I think that we could probably just skip TensorFlow in these tests. Thoughts?
|
CI is currently failing for Apple silicon macOS. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 69 69
Lines 4543 4546 +3
Branches 804 805 +1
=======================================
+ Hits 4462 4465 +3
Misses 48 48
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kratsg
reviewed
Apr 18, 2024
| @@ -15,7 +15,8 @@ def __dir__(): | |||
|
|
|||
| def _interp(x, xp, fp): | |||
There was a problem hiding this comment.
Suggested change
| def _interp(x, xp, fp): | |
| def _interp(x, xp: list[float], fp): |
kratsg
reviewed
Apr 18, 2024
| @@ -15,7 +15,8 @@ def __dir__(): | |||
|
|
|||
| def _interp(x, xp, fp): | |||
| tb, _ = get_backend() | |||
| return tb.astensor(np.interp(x, xp.tolist(), fp.tolist())) | |||
| # xp has already been turned into a list at this point | |||
There was a problem hiding this comment.
can drop this comment with a typehint above as suggested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2466
As
toms748_scanuses caching of results it requires that the results are hashable objects, which arrays are not. So to keep using this approach convert to floats as needed.Add testing for all backends for the upper limits inference tests.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: