Make the wheel repairing configurable

Signed-off-by: Cristian Le <[email protected]>

Author: LecrisUT

README.md

@@ -223,6 +223,12 @@ wheel.build-tag = ""
 # Do automatic repairs of the compiled binaries and libraries.
 wheel.repair.enable = false
 
+# Patch the dynamic links to libraries installed in the current wheel.
+wheel.repair.in-wheel = true
+
+# Patch the dynamic links to libraries in other wheels.
+wheel.repair.cross-wheel = false
+
 # If CMake is less than this value, backport a copy of FindPython.
 backport.find-python = "3.26.1"
 

docs/reference/configs.md

@@ -576,6 +576,19 @@ print(mk_skbuild_docs())
 
 ## wheel.repair
 
+```{eval-rst}
+.. confval:: wheel.repair.cross-wheel
+  :type: ``bool``
+  :default: false
+
+  Patch the dynamic links to libraries in other wheels.
+
+  .. note::
+     This may result in incompatible wheels. Use this only if the
+     wheels are strongly linked to each other and strict manylinux compliance is
+     not required.
+```
+
 ```{eval-rst}
 .. confval:: wheel.repair.enable
   :type: ``bool``
@@ -587,4 +600,12 @@ print(mk_skbuild_docs())
      This is an experimental feature gated by :confval:`experimental`
 ```
 
+```{eval-rst}
+.. confval:: wheel.repair.in-wheel
+  :type: ``bool``
+  :default: true
+
+  Patch the dynamic links to libraries installed in the current wheel.
+```
+
 <!-- [[[end]]] -->

src/scikit_build_core/repair_wheel/rpath.py

@@ -164,8 +164,14 @@ def patch_target(self, target: Target) -> None:
         for install_path in target_install_paths:
             target_path = self.install_dir / install_path
             artifact_path = target_path / artifact.path.name
-            dependency_rpaths = self.get_dependency_rpaths(target, install_path)
-            package_rpaths = self.get_package_rpaths(target, install_path)
+            if self.settings.wheel.repair.in_wheel:
+                dependency_rpaths = self.get_dependency_rpaths(target, install_path)
+            else:
+                dependency_rpaths = []
+            if self.settings.wheel.repair.cross_wheel:
+                package_rpaths = self.get_package_rpaths(target, install_path)
+            else:
+                package_rpaths = []
             existing_rpaths = self.get_existing_rpaths(artifact_path)
             logger.debug(
                 "Patching rpaths for artifact {artifact}\n"

src/scikit_build_core/repair_wheel/windows.py

@@ -210,8 +210,15 @@ def get_package_dll(self, target: Target) -> list[Path]:
 
     def patch_target(self, target: Target) -> None:
         # Here we just gather all dll paths needed for each target
-        package_dlls = self.get_package_dll(target)
-        dependency_dlls = self.get_dependency_dll(target)
+        if self.settings.wheel.repair.in_wheel:
+            dependency_dlls = self.get_dependency_dll(target)
+        else:
+            dependency_dlls = []
+        if self.settings.wheel.repair.cross_wheel:
+            package_dlls = self.get_package_dll(target)
+        else:
+            package_dlls = []
+
         if not package_dlls and not dependency_dlls:
             logger.warning(
                 "No dll files found for target {target}",

src/scikit_build_core/resources/scikit-build.schema.json

@@ -248,6 +248,16 @@
               "type": "boolean",
               "default": false,
               "description": "Do automatic repairs of the compiled binaries and libraries."
+            },
+            "in-wheel": {
+              "type": "boolean",
+              "default": true,
+              "description": "Patch the dynamic links to libraries installed in the current wheel."
+            },
+            "cross-wheel": {
+              "type": "boolean",
+              "default": false,
+              "description": "Patch the dynamic links to libraries in other wheels."
             }
           },
           "description": "Wheel repair options"

src/scikit_build_core/settings/skbuild_model.py

@@ -232,6 +232,21 @@ class WheelRepair:
        This is an experimental feature gated by :confval:`experimental`
     """
 
+    in_wheel: bool = True
+    """
+    Patch the dynamic links to libraries installed in the current wheel.
+    """
+
+    cross_wheel: bool = False
+    """
+    Patch the dynamic links to libraries in other wheels.
+
+    .. note::
+       This may result in incompatible wheels. Use this only if the
+       wheels are strongly linked to each other and strict manylinux compliance is
+       not required.
+    """
+
 
 @dataclasses.dataclass
 class WheelSettings:

tests/packages/repair_wheel/pyproject.toml

@@ -11,6 +11,7 @@ dependencies = ["base_project"]
 build.requires = ["base_project @ {root:uri}/extern"]
 wheel.install-dir = "repair_wheel"
 wheel.repair.enable = true
+wheel.repair.cross-wheel = true
 experimental = true
 
 [project.scripts]