Skip to content

Commit e47f077

Browse files
committed
ShadowMenu: compare objects using MiscUtils
This is easier to read than doing all sorts of null checks.
1 parent 709e247 commit e47f077

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/main/java/org/scijava/menu/ShadowMenu.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
import org.scijava.module.ModuleService;
5555
import org.scijava.plugin.Parameter;
5656
import org.scijava.util.ClassUtils;
57+
import org.scijava.util.MiscUtils;
5758

5859
/**
5960
* A tree representing a menu structure independent of any particular user
@@ -291,9 +292,7 @@ public int compareTo(final ShadowMenu c) {
291292
// if weights are equal, sort alphabetically
292293
final String n1 = menuEntry.getName();
293294
final String n2 = c.menuEntry.getName();
294-
final String s1 = n1 == null ? "" : n1;
295-
final String s2 = n2 == null ? "" : n2;
296-
return s1.compareTo(s2);
295+
return MiscUtils.compare(n1, n2);
297296
}
298297

299298
@Override

0 commit comments

Comments
 (0)