From 477388eda36bc2bc9d82c7bdb45acf4385e169fa Mon Sep 17 00:00:00 2001
From: Glenn <git@scidsg.org>
Date: Fri, 6 Sep 2024 20:01:37 -0700
Subject: [PATCH 1/2] Fix rendering of empty extra_fields

---
 hushline/templates/profile.html | 46 ++++++++++++++++-----------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/hushline/templates/profile.html b/hushline/templates/profile.html
index 76059da76..1eb2ea241 100644
--- a/hushline/templates/profile.html
+++ b/hushline/templates/profile.html
@@ -46,30 +46,30 @@ <h2 class="submit">
       {'label': user.extra_field_label4, 'value': user.extra_field_value4, 'verified': user.extra_field_verified4}
     ]
   %}
-
-  {% if extra_fields | selectattr('label', 'defined') | selectattr('value', 'defined') %}
+  
+  {%- set valid_fields = extra_fields | selectattr('label', 'defined') | selectattr('value', 'defined') | selectattr('value') | list -%}
+  
+  {% if valid_fields | length > 0 %}
     <div class="extra-fields">
-      {% for field in extra_fields %}
-        {% if field.label and field.value %}
-          <p class="extra-field">
-            <span class="extra-field-label">{{ field.label }}</span>
-            <span class="extra-field-value">
-              {% if field.verified %}
-                <span class="icon verifiedURL" title="Verified Address"></span>
-              {% endif %}
-              {% if field.value.startswith('https://') %}
-                <a
-                  href="{{ field.value }}"
-                  target="_blank"
-                  rel="noopener noreferrer me"
-                  >{{ field.value }}</a
-                >
-              {% else %}
-                {{ field.value }}
-              {% endif %}
-            </span>
-          </p>
-        {% endif %}
+      {% for field in valid_fields %}
+        <p class="extra-field">
+          <span class="extra-field-label">{{ field.label }}</span>
+          <span class="extra-field-value">
+            {% if field.verified %}
+              <span class="icon verifiedURL" title="Verified Address"></span>
+            {% endif %}
+            {% if field.value.startswith('https://') %}
+              <a
+                href="{{ field.value }}"
+                target="_blank"
+                rel="noopener noreferrer me"
+                >{{ field.value }}</a
+              >
+            {% else %}
+              {{ field.value }}
+            {% endif %}
+          </span>
+        </p>
       {% endfor %}
     </div>
   {% endif %}

From 64f01acf7ed0d8f8b7f063934571e6b0a61acace Mon Sep 17 00:00:00 2001
From: Glenn <git@scidsg.org>
Date: Fri, 6 Sep 2024 20:05:59 -0700
Subject: [PATCH 2/2] Update profile.html

---
 hushline/templates/profile.html | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hushline/templates/profile.html b/hushline/templates/profile.html
index 1eb2ea241..dad1db3fd 100644
--- a/hushline/templates/profile.html
+++ b/hushline/templates/profile.html
@@ -46,9 +46,8 @@ <h2 class="submit">
       {'label': user.extra_field_label4, 'value': user.extra_field_value4, 'verified': user.extra_field_verified4}
     ]
   %}
-  
   {%- set valid_fields = extra_fields | selectattr('label', 'defined') | selectattr('value', 'defined') | selectattr('value') | list -%}
-  
+
   {% if valid_fields | length > 0 %}
     <div class="extra-fields">
       {% for field in valid_fields %}